Clean up formatting in dom/events/DataTransfer.* and mark some methods const

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

47 Branch
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: btpp-active)

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8744289 [details] [diff] [review]
dataTransfer1.patch
Attachment #8744289 - Flags: review?(jwatt)
Comment on attachment 8744289 [details] [diff] [review]
dataTransfer1.patch

Review of attachment 8744289 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/events/DataTransfer.cpp
@@ +1163,5 @@
>    if (type == nsIDataType::VTYPE_INTERFACE ||
>        type == nsIDataType::VTYPE_INTERFACE_IS) {
>      nsCOMPtr<nsISupports> data;
> +    if (NS_FAILED(aVariant->GetAsISupports(getter_AddRefs(data)))) {
> +     return false;

Extra space here.

@@ +1469,5 @@
> +    nsAutoString str;
> +    supportsstr->GetData(str);
> +    variant->SetAsAString(str);
> +  }
> +  else {

Make this

} else {
Attachment #8744289 - Flags: review?(jwatt) → review+

Updated

3 years ago
Summary: Some indentation issues in dom/events/DataTransfer.* → Clean up formatting in dom/events/DataTransfer.* and mark some methods const
Whiteboard: btpp-active

Comment 3

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/50dd2630d804
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.