Closed Bug 1266702 Opened 7 years ago Closed 7 years ago

Clean up formatting in dom/events/DataTransfer.* and mark some methods const

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Version:
47 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

dataTransfer1.patch
34.00 KB, patch
jwatt
: review+
Details | Diff | Splinter Review 
      No description provided.
Attachment #8744289 - Flags: review?(jwatt)
Comment on attachment 8744289 [details] [diff] [review]
dataTransfer1.patch

Review of attachment 8744289 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/events/DataTransfer.cpp
@@ +1163,5 @@
>    if (type == nsIDataType::VTYPE_INTERFACE ||
>        type == nsIDataType::VTYPE_INTERFACE_IS) {
>      nsCOMPtr<nsISupports> data;
> +    if (NS_FAILED(aVariant->GetAsISupports(getter_AddRefs(data)))) {
> +     return false;

Extra space here.

@@ +1469,5 @@
> +    nsAutoString str;
> +    supportsstr->GetData(str);
> +    variant->SetAsAString(str);
> +  }
> +  else {

Make this

} else {
Attachment #8744289 - Flags: review?(jwatt) → review+
Summary: Some indentation issues in dom/events/DataTransfer.* → Clean up formatting in dom/events/DataTransfer.* and mark some methods const
Whiteboard: btpp-active
https://hg.mozilla.org/mozilla-central/rev/50dd2630d804
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.