1266709 - Background content is overlapped when opening a new Private tab

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Simon Basca [:SimonB]]

Build: 4.0.0b3

Steps to reproduce:
1. Launch Firefox
2. Go to settings menu
3. Swipe down to open Today widget menu
4. Tap on the "New Private Tab" button

Actual results: 
- The background content will be overlapped with the opened private browsing tab and the application will be in an unresponsive state

Expected results:
- The background content should not be displayed after opening a new private browsing tab and the app should nor be unresponsive

Note: 
- This issue is reproducible on IPhone 6S using 3D Touch feature following the below steps:
1. Launch Firefox
2. Go to settings menu
3. Background Firefox by pressing the home button
4. Press firmly on the icon to bring up 3D Touch options
5. Open a new in Private Browsing tab

Comment 1

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Some comments in the bug.

Comment 3

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8746040 [details] [review]
Pull request

r+ with nits.

Comment 4

[Emily Toop (:fluffyemily)]

#merged https://github.com/mozilla/firefox-ios/commit/3f4d34cbc2a7eb87e22df533d16cbcea01c69ff4

Comment 5

[Stephan Leroux [:sleroux]]

I'm running into some merge conflicts uplifting this commit onto v4.x. In particular, I'm not 100% sure that this is what we want:

https://www.dropbox.com/s/rt7v24gqrqyl7kp/Screenshot%202016-04-28%2016.29.25.png?dl=0

I know that Browser got renamed to Tab but what is the difference between passing it in as a param or not?

Comment 6

[Emily Toop (:fluffyemily)]

(In reply to Stephan Leroux [:sleroux] from comment #5)
> I'm running into some merge conflicts uplifting this commit onto v4.x. In
> particular, I'm not 100% sure that this is what we want:
> 
> https://www.dropbox.com/s/rt7v24gqrqyl7kp/Screenshot%202016-04-28%2016.29.25.
> png?dl=0
> 
> I know that Browser got renamed to Tab but what is the difference between
> passing it in as a param or not?

The only difference is that before we were using the passed in tab for something, and after we're not so I removed the tab arg.

Comment 7

[Simon Basca [:SimonB]]

Tested on build 4.0.0b7.

The issue no longer reproducible.