Closed
Bug 1266715
Opened 8 years ago
Closed 8 years ago
Fix the space between the blinking cursor/selection highlight and the carets
Categories
(Firefox for Android Graveyard :: Text Selection, defect)
Firefox for Android Graveyard
Text Selection
Tracking
(firefox47 unaffected, firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox47 | --- | unaffected |
firefox48 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
(Keywords: regression)
Attachments
(3 files)
This is a follow-up of bug 1262755. I changed the style of the carets image from "bottom: 0" to "top: 0", this causes the offset in content.css [1] become malfunction. So the caret image will be too close to the blinking cursor on Fennec. Other platforms do not have this issue because they do not have these offset. [1] https://dxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/content.css#342,348,354
Assignee | ||
Comment 1•8 years ago
|
||
The permanent link of [1] in comment 0: https://dxr.mozilla.org/mozilla-central/rev/0891f0fa044cba28024849803e170ed7700e01e0/mobile/android/themes/core/content.css#342,348,354
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/48449/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48449/
Attachment #8744307 -
Flags: review?(snorp)
Assignee | ||
Updated•8 years ago
|
Keywords: regression
Assignee | ||
Comment 3•8 years ago
|
||
This is the screenshot of the correct space between the blinking cursor and the caret, which is the same before fixing bug 1262755.
Comment on attachment 8744307 [details] MozReview Request: Bug 1266715 - Fix space between blinking cursor/selection highlight and the caret. https://reviewboard.mozilla.org/r/48449/#review45169
Attachment #8744307 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Try results look good. https://treeherder.mozilla.org/#/jobs?repo=try&revision=c63a8cccb342&selectedJob=19856369
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8f0b8d0c6bc3
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•8 years ago
|
status-firefox47:
--- → unaffected
Version: unspecified → Trunk
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•