Closed
Bug 1266733
Opened 8 years ago
Closed 8 years ago
Attributes of selected element are barely readable in Firebug theme
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(firefox48 fixed, firefox49 fixed)
VERIFIED
FIXED
Firefox 49
People
(Reporter: sebo, Assigned: Honza)
References
Details
Attachments
(2 files, 1 obsolete file)
5.68 KB,
image/png
|
Details | |
2.63 KB,
patch
|
Honza
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
When a node is selected within the Inspector panel while using the Firebug theme, the attributes are not readable. All text within the selected element should be shown in white letters instead (including the arrow brackets of the tags). Sebastian
Assignee | ||
Comment 1•8 years ago
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8744914 [details] [diff] [review] bug1266733.patch Review of attachment 8744914 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/themes/markup.css @@ +292,5 @@ > .theme-selected ~ .editor .theme-fg-color7 { > color: var(--theme-selection-color); > } > > +/* Make sure even text nodes are white when selected in the Inspector panel. */ Not a big fan of these overrides in general and I'd rather see :not(.theme-selected) added into the selectors above, but that looks complicated due to the sibling selector so I guess this works. I don't think .editable is really needed in this list. That element should nested under .open so it should inherit the right color. Unless if there's a reason for it to be there, please remove it.
Attachment #8744914 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to (Unavailable until April 25) Brian Grinstead [:bgrins] from comment #2) > I don't think .editable is really needed in this list. That element should > nested under .open so it should inherit the right color. True, removed. Honza
Attachment #8744914 -
Attachment is obsolete: true
Attachment #8744933 -
Flags: review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/62646acf6872
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Reporter | ||
Comment 6•8 years ago
|
||
Looks good to me. Thanks for the quick fix! Sebastian
Status: RESOLVED → VERIFIED
Comment 7•8 years ago
|
||
Comment on attachment 8744933 [details] [diff] [review] bug1266733.patch Approval Request Comment [Feature/regressing bug #]: Firebug theme [User impact if declined]: Unreadable text on selected inspector item [Describe test coverage new/current, TreeHerder]: Verified in Nightly [Risks and why]: Low, CSS only [String/UUID change made/needed]: none
Attachment #8744933 -
Flags: approval-mozilla-aurora?
Comment on attachment 8744933 [details] [diff] [review] bug1266733.patch Firebug theme related and the fix was verified on Nightly, Aurora48+
Attachment #8744933 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/2312ffc95866
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•