Status

Firefox OS
Runtime
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gerard, Assigned: gerard)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 8745976 [details] [review]
[gaia] lissyx:bug1266756 > mozilla-b2g:kanikani
(Assignee)

Updated

2 years ago
Depends on: 1268027
(Assignee)

Updated

2 years ago
Depends on: 1263308
(Assignee)

Comment 6

2 years ago
I had to disable a few asserts within some tests because of bug 1268477
(Assignee)

Updated

2 years ago
Attachment #8745976 - Flags: review?(aus)

Comment 8

2 years ago
Comment on attachment 8745976 [details] [review]
[gaia] lissyx:bug1266756 > mozilla-b2g:kanikani

lgtm! some notes on github (mostly things that looked like you were going to delete but hadn't gotten around to yet). Everything else looks good.
Attachment #8745976 - Flags: review?(aus) → review+
(Assignee)

Updated

2 years ago
Blocks: 1268808
(Assignee)

Comment 9

2 years ago
(In reply to Aus Lacroix [:aus] from comment #8)
> Comment on attachment 8745976 [details] [review]
> [gaia] lissyx:bug1266756 > mozilla-b2g:kanikani
> 
> lgtm! some notes on github (mostly things that looked like you were going to
> delete but hadn't gotten around to yet). Everything else looks good.

Fixed most of them, but I kept some on purpose :)
(Assignee)

Comment 10

2 years ago
https://github.com/mozilla-b2g/gaia/commit/412e41940c36b80bb4f765961b1cb426b8fc9732
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.