Closed Bug 1266756 Opened 4 years ago Closed 4 years ago

Get Gb tests suite green

Categories

(Firefox OS Graveyard :: Runtime, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

Attachments

(1 file)

No description provided.
Depends on: 1268027
Depends on: 1263308
I had to disable a few asserts within some tests because of bug 1268477
Attachment #8745976 - Flags: review?(aus)
Comment on attachment 8745976 [details] [review]
[gaia] lissyx:bug1266756 > mozilla-b2g:kanikani

lgtm! some notes on github (mostly things that looked like you were going to delete but hadn't gotten around to yet). Everything else looks good.
Attachment #8745976 - Flags: review?(aus) → review+
Blocks: 1268808
(In reply to Aus Lacroix [:aus] from comment #8)
> Comment on attachment 8745976 [details] [review]
> [gaia] lissyx:bug1266756 > mozilla-b2g:kanikani
> 
> lgtm! some notes on github (mostly things that looked like you were going to
> delete but hadn't gotten around to yet). Everything else looks good.

Fixed most of them, but I kept some on purpose :)
https://github.com/mozilla-b2g/gaia/commit/412e41940c36b80bb4f765961b1cb426b8fc9732
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.