Closed
Bug 1266779
Opened 8 years ago
Closed 8 years ago
No placeholder icons for search engines without icon in the Search pane treeview
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 49
People
(Reporter: florian, Assigned: florian)
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
|
1.14 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
When a search plugin doesn't have an icon, we display instead chrome://browser/skin/search-engine-placeholder[@2x].png, except for the preference window that just shows an empty area instead of the icon.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8744376 -
Flags: review?(gijskruitbosch+bugs)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8744376 [details] [diff] [review] Fix Review of attachment 8744376 [details] [diff] [review]: ----------------------------------------------------------------- r=me if you hg rm all the per-platform preferences search.css files which are no longer used (we use the in-content one instead), and remove them from their respective manifests where necessary.
Attachment #8744376 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a0868d83ff41797c0c1361d6fe6b8a6a41f048a3 Bug 1266779 - Show placeholder icons in the search preferences for engines without icon, r=Gijs.
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a0868d83ff41
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in
before you can comment on or make changes to this bug.
Description
•