1266804 - js::Unbox() shouldn't declared inline in Class.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[(no longer active)]

<https://dxr.mozilla.org/mozilla-central/source/js/public/Class.h#963>

This causes embedders who call this function to always get a warning they can't bypass, like:

../deps/spidershim/build-debug/dist/include/js/Class.h:964:1: warning: inline function 'js::Unbox' is not defined [-Wundefined-inline]
Unbox(JSContext* cx, JS::HandleObject obj, JS::MutableHandleValue vp);
^
../deps/spidershim/src/v8stringobject.cc:52:12: note: used here
  if (!js::Unbox(cx, thisObj, &unboxedVal)) {
           ^

Jason, should we fix this?

Comment 1

[Jason Orendorff [:jorendorff]]

Yes. The definition is in jsobjinlines.h, but AFAICT it shouldn't be. Moving to jsobj.cpp and removing `inline` from the declaration would be fine.

Comment 2

[(no longer active)]

Attachment: Un-inline js::Unbox()

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c9ff56dbb6fc

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c9ff56dbb6fc