Closed
Bug 1266820
Opened 8 years ago
Closed 8 years ago
Temporarily disable screenshot in bookmarks
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(1 file)
It makes people annoyed with the notification. More importantly, we're inserting a bunch of garbage screenshot data into the Url Annotations table, which is going to make testing screenshot signals harder in the future (for users with garbage data).
Assignee | ||
Comment 1•8 years ago
|
||
See code comment (and related bug) for details. Review commit: https://reviewboard.mozilla.org/r/48537/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48537/
Attachment #8744429 -
Flags: review?(gkruglov)
Comment 2•8 years ago
|
||
Comment on attachment 8744429 [details] MozReview Request: Bug 1266820 - Disable Screenshot in Bookmarks feature. r=grisha r=grisha https://reviewboard.mozilla.org/r/48537/#review45267 "There's nothing so permanent as temporary"
Attachment #8744429 -
Flags: review?(gkruglov) → review+
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to :Grisha Kruglov from comment #2) > "There's nothing so permanent as temporary" :|
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/3bc647d9bb02ea0284ea7653161f49c9dd2982e4 Bug 1266820 - Disable Screenshot in Bookmarks feature. r=grisha r=grisha
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #3) > > "There's nothing so permanent as temporary" > > :| lol: https://niksilver.files.wordpress.com/2007/09/temporary-workaround2.jpg?w=750
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3bc647d9bb02
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment 7•8 years ago
|
||
Does this need to happen at build time? Can this feature be controlled by a switchboard flag?
Assignee | ||
Comment 8•8 years ago
|
||
(In reply to :Margaret Leibovic from comment #7) > Does this need to happen at build time? Can this feature be controlled by a > switchboard flag? We could do this via switchboard – would you like me to file a follow-up bug?
Flags: needinfo?(margaret.leibovic)
Comment 9•8 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #8) > (In reply to :Margaret Leibovic from comment #7) > > Does this need to happen at build time? Can this feature be controlled by a > > switchboard flag? > > We could do this via switchboard – would you like me to file a follow-up bug? Yes, please! <3
Flags: needinfo?(margaret.leibovic) → needinfo?(michael.l.comella)
Assignee | ||
Comment 10•8 years ago
|
||
(In reply to :Margaret Leibovic from comment #9) > (In reply to Michael Comella (:mcomella) from comment #8) > > (In reply to :Margaret Leibovic from comment #7) > > > Does this need to happen at build time? Can this feature be controlled by a > > > switchboard flag? > > > > We could do this via switchboard – would you like me to file a follow-up bug? > > Yes, please! <3 bug 1269051.
Flags: needinfo?(michael.l.comella)
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•