1266820 - Temporarily disable screenshot in bookmarks

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[Michael Comella (:mcomella) [needinfo or I won't see it]]

It makes people annoyed with the notification.

More importantly, we're inserting a bunch of garbage screenshot data into the Url Annotations table, which is going to make testing screenshot signals harder in the future (for users with garbage data).

Comment 1

[Michael Comella (:mcomella) [needinfo or I won't see it]]

Attachment: MozReview Request: Bug 1266820 - Disable Screenshot in Bookmarks feature. r=grisha r=grisha

See code comment (and related bug) for details.

Review commit: https://reviewboard.mozilla.org/r/48537/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48537/

Comment 2

[:Grisha Kruglov]

Comment on attachment 8744429 [details]
MozReview Request: Bug 1266820 - Disable Screenshot in Bookmarks feature. r=grisha r=grisha

https://reviewboard.mozilla.org/r/48537/#review45267

"There's nothing so permanent as temporary"

Comment 3

[Michael Comella (:mcomella) [needinfo or I won't see it]]

(In reply to :Grisha Kruglov from comment #2)
> "There's nothing so permanent as temporary"

:|

Comment 4

[Michael Comella (:mcomella) [needinfo or I won't see it]]

https://hg.mozilla.org/integration/fx-team/rev/3bc647d9bb02ea0284ea7653161f49c9dd2982e4
Bug 1266820 - Disable Screenshot in Bookmarks feature. r=grisha r=grisha

Comment 5

[Michael Comella (:mcomella) [needinfo or I won't see it]]

(In reply to Michael Comella (:mcomella) from comment #3)
> > "There's nothing so permanent as temporary"
> 
> :|

lol: https://niksilver.files.wordpress.com/2007/09/temporary-workaround2.jpg?w=750

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3bc647d9bb02

Comment 7

[:Margaret Leibovic]

Does this need to happen at build time? Can this feature be controlled by a switchboard flag?

Comment 8

[Michael Comella (:mcomella) [needinfo or I won't see it]]

(In reply to :Margaret Leibovic from comment #7)
> Does this need to happen at build time? Can this feature be controlled by a
> switchboard flag?

We could do this via switchboard – would you like me to file a follow-up bug?

Comment 9

[:Margaret Leibovic]

(In reply to Michael Comella (:mcomella) from comment #8)
> (In reply to :Margaret Leibovic from comment #7)
> > Does this need to happen at build time? Can this feature be controlled by a
> > switchboard flag?
> 
> We could do this via switchboard – would you like me to file a follow-up bug?

Yes, please! <3

Comment 10

[Michael Comella (:mcomella) [needinfo or I won't see it]]

(In reply to :Margaret Leibovic from comment #9)
> (In reply to Michael Comella (:mcomella) from comment #8)
> > (In reply to :Margaret Leibovic from comment #7)
> > > Does this need to happen at build time? Can this feature be controlled by a
> > > switchboard flag?
> > 
> > We could do this via switchboard – would you like me to file a follow-up bug?
> 
> Yes, please! <3

bug 1269051.