Closed Bug 1266820 Opened 5 years ago Closed 5 years ago

Temporarily disable screenshot in bookmarks

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It makes people annoyed with the notification.

More importantly, we're inserting a bunch of garbage screenshot data into the Url Annotations table, which is going to make testing screenshot signals harder in the future (for users with garbage data).
Comment on attachment 8744429 [details]
MozReview Request: Bug 1266820 - Disable Screenshot in Bookmarks feature. r=grisha r=grisha

https://reviewboard.mozilla.org/r/48537/#review45267

"There's nothing so permanent as temporary"
Attachment #8744429 - Flags: review?(gkruglov) → review+
(In reply to :Grisha Kruglov from comment #2)
> "There's nothing so permanent as temporary"

:|
(In reply to Michael Comella (:mcomella) from comment #3)
> > "There's nothing so permanent as temporary"
> 
> :|

lol: https://niksilver.files.wordpress.com/2007/09/temporary-workaround2.jpg?w=750
https://hg.mozilla.org/mozilla-central/rev/3bc647d9bb02
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Does this need to happen at build time? Can this feature be controlled by a switchboard flag?
(In reply to :Margaret Leibovic from comment #7)
> Does this need to happen at build time? Can this feature be controlled by a
> switchboard flag?

We could do this via switchboard – would you like me to file a follow-up bug?
Flags: needinfo?(margaret.leibovic)
(In reply to Michael Comella (:mcomella) from comment #8)
> (In reply to :Margaret Leibovic from comment #7)
> > Does this need to happen at build time? Can this feature be controlled by a
> > switchboard flag?
> 
> We could do this via switchboard – would you like me to file a follow-up bug?

Yes, please! <3
Flags: needinfo?(margaret.leibovic) → needinfo?(michael.l.comella)
(In reply to :Margaret Leibovic from comment #9)
> (In reply to Michael Comella (:mcomella) from comment #8)
> > (In reply to :Margaret Leibovic from comment #7)
> > > Does this need to happen at build time? Can this feature be controlled by a
> > > switchboard flag?
> > 
> > We could do this via switchboard – would you like me to file a follow-up bug?
> 
> Yes, please! <3

bug 1269051.
Flags: needinfo?(michael.l.comella)
You need to log in before you can comment on or make changes to this bug.