1266828 - turn ViewHelpers.jsm into a .js

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Tom Tromey :tromey]

For the devtools de-chrome-ification project, we'll need to turn
ViewHelpers.jsm into a .js.
This may require some investigation; maybe it ought to be split up.

Comment 1

[Alexandre Poirot [:ochameau]]

Getting rid of jsm, something for me!

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

Comment 3

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f953a5f0b08

Comment 4

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f721bec4cc47

Comment 5

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f658189f6a30

Comment 6

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d1f6df2be9c

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: patch v2

Fixes tests.

Tom, In this patch, I only converted to a module.
I haven't tried to split view-helpers.
But it would be easy now that we have explicit require.
We can easily grep for modules using X or Y exported method!

So just tell me if we should pull out timeout/heritage.

Comment 8

[Tom Tromey :tromey]

Comment on attachment 8752190 [details] [diff] [review]
patch v2

Review of attachment 8752190 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.
Looks great.

Comment 9

[Tom Tromey :tromey]

(In reply to Alexandre Poirot [:ochameau] from comment #7)

> So just tell me if we should pull out timeout/heritage.

I think it's probably ok as-is.
I saw in your patch that client code uses most (I think) parts of the file;
my main concern was that maybe some bits wouldn't be usable on the client side.
If we encounter problems we can always split it later if we need to.

Comment 10

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/f10ea2e1322bce13823bd6c4b263a31ca1d9bdc0
Bug 1266828 - Convert ViewHelpers.jsm into a module. r=tromey

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f10ea2e1322b