turn ViewHelpers.jsm into a .js

RESOLVED FIXED in Firefox 49

Status

DevTools
Framework
P1
enhancement
RESOLVED FIXED
2 years ago
9 days ago

People

(Reporter: tromey, Assigned: ochameau)

Tracking

unspecified
Firefox 49
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: [devtools-html])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

2 years ago
For the devtools de-chrome-ification project, we'll need to turn
ViewHelpers.jsm into a .js.
This may require some investigation; maybe it ought to be split up.

Updated

2 years ago
Flags: qe-verify-
Priority: -- → P2
(Assignee)

Comment 1

2 years ago
Getting rid of jsm, something for me!
Assignee: nobody → poirot.alex

Updated

2 years ago
Blocks: 1259121
No longer blocks: 1263287
Status: NEW → ASSIGNED
Iteration: --- → 49.2 - May 23
Priority: P2 → P1
(Assignee)

Comment 7

2 years ago
Created attachment 8752190 [details] [diff] [review]
patch v2

Fixes tests.

Tom, In this patch, I only converted to a module.
I haven't tried to split view-helpers.
But it would be easy now that we have explicit require.
We can easily grep for modules using X or Y exported method!

So just tell me if we should pull out timeout/heritage.
Attachment #8752190 - Flags: review?(ttromey)
(Assignee)

Updated

2 years ago
Attachment #8751663 - Attachment is obsolete: true
(Reporter)

Comment 8

2 years ago
Comment on attachment 8752190 [details] [diff] [review]
patch v2

Review of attachment 8752190 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.
Looks great.
Attachment #8752190 - Flags: review?(ttromey) → review+
(Reporter)

Comment 9

2 years ago
(In reply to Alexandre Poirot [:ochameau] from comment #7)

> So just tell me if we should pull out timeout/heritage.

I think it's probably ok as-is.
I saw in your patch that client code uses most (I think) parts of the file;
my main concern was that maybe some bits wouldn't be usable on the client side.
If we encounter problems we can always split it later if we need to.

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f10ea2e1322b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49

Updated

2 years ago
Iteration: 49.3 - Jun 6 → 49.2 - May 23

Updated

2 years ago
Iteration: 49.2 - May 23 → 49.3 - Jun 6

Updated

9 days ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.