Closed Bug 1266829 Opened 8 years ago Closed 8 years ago

Five second freeze after adding a tag to a newly-bookmarked page due to main-thread sqlite use [@ findMobileRoot] with Firefox Sync

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1302901

People

(Reporter: mstange, Unassigned)

References

Details

I'm using today's nightly.

STR:
 1. Press the star in the toolbar.
 2. Type "@read" into the tags text field.
 3. Press enter.

The whole browser will freeze for a few seconds.

Using the profiler, I found out that the call stack is:

    mozilla::storage::Statement::ExecuteStep(bool*)
    nsAnnotationService::GetItemsWithAnnotationTArray
    nsAnnotationService::GetItemsWithAnnotation
    findMobileRoot() @ bookmarks.js:156
    specialIdForGUID() @ bookmarks.js:173
    specialGUIDForId() @ bookmarks.js:181
    _buildGUIDMap() @ bookmarks.js:273
    _syncStart/<() @ bookmarks.js:439
    _mapDupe() @ bookmarks.js:354
    _createRecord() @ bookmarks.js:483
    SyncEngine.prototype._uploadOutgoing() @ engines.js:1448
    SyncEngine.prototype._sync() @ engines.js:1551
    wrappedSync() @ bookmarks.js:227
    _sync() @ bookmarks.js:221
    WrappedNotify() @ util.js:143
    Engine.prototype.sync() @ engines.js:661
    _syncEngine() @ enginesync.js:211
    sync() @ enginesync.js:34
    onNotify() @ service.js:1253
    WrappedNotify() @ util.js:143
    WrappedLock() @ util.js:95
    _lockedSync() @ service.js:1251
    sync/<() @ service.js:1232
    WrappedCatch() @ util.js:73
    sync() @ service.js:1228
Component: Bookmarks & History → Sync
Smells like a regression from bug 655722.
Blocks: 655722
We've added a mobile root in bug 1302901, and removed the `findMobileRoot` function responsible for the main-thread SQLite query.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.