1266835 - Request names from the rootlist in JS::ubi::dumpPaths and clean up formatting of dumped paths

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Request names from the rootlist in JS::ubi::dumpPaths and clean up formatting of dumped paths

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e8ae7713b7d

Comment 3

[Jim Blandy :jimb]

Comment on attachment 8744452 [details] [diff] [review]
Request names from the rootlist in JS::ubi::dumpPaths and clean up formatting of dumped paths

Review of attachment 8744452 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/UbiNodeShortestPaths.cpp
@@ +55,5 @@
> +
> +            auto typeName = backEdge->predecessor().typeName();
> +            auto len = js_strlen(typeName);
> +            for (size_t i = 0; i < len; i++)
> +                fprintf(stderr, "%c", char(typeName[i]));

This is too bad. Could you implement js_fputs in jsstr.{cpp,h}, and then call it here and below?

Also, you can always use fputwc in the implementation, not fprintf(..., "%c", ...), or fputc if casting char16_t to wchar_t is too gross.

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Request names from the rootlist in JS::ubi::dumpPaths and clean up formatting of dumped paths

Now with js_fputs!

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=365930752210

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46d7944da816

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/46d7944da816

Comment 8

[Jim Blandy :jimb]

Comment on attachment 8744524 [details] [diff] [review]
Request names from the rootlist in JS::ubi::dumpPaths and clean up formatting of dumped paths

Review of attachment 8744524 [details] [diff] [review]:
-----------------------------------------------------------------

YAS