Closed
Bug 1266835
Opened 8 years ago
Closed 8 years ago
Request names from the rootlist in JS::ubi::dumpPaths and clean up formatting of dumped paths
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file, 1 obsolete file)
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8744452 -
Flags: review?(jimb)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e8ae7713b7d
Comment 3•8 years ago
|
||
Comment on attachment 8744452 [details] [diff] [review] Request names from the rootlist in JS::ubi::dumpPaths and clean up formatting of dumped paths Review of attachment 8744452 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/vm/UbiNodeShortestPaths.cpp @@ +55,5 @@ > + > + auto typeName = backEdge->predecessor().typeName(); > + auto len = js_strlen(typeName); > + for (size_t i = 0; i < len; i++) > + fprintf(stderr, "%c", char(typeName[i])); This is too bad. Could you implement js_fputs in jsstr.{cpp,h}, and then call it here and below? Also, you can always use fputwc in the implementation, not fprintf(..., "%c", ...), or fputc if casting char16_t to wchar_t is too gross.
Attachment #8744452 -
Flags: review?(jimb) → review+
Assignee | ||
Updated•8 years ago
|
Attachment #8744452 -
Attachment is obsolete: true
Assignee | ||
Comment 5•8 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=365930752210
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/46d7944da816
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 8•8 years ago
|
||
Comment on attachment 8744524 [details] [diff] [review] Request names from the rootlist in JS::ubi::dumpPaths and clean up formatting of dumped paths Review of attachment 8744524 [details] [diff] [review]: ----------------------------------------------------------------- YAS
You need to log in
before you can comment on or make changes to this bug.
Description
•