Request names from the rootlist in JS::ubi::dumpPaths and clean up formatting of dumped paths

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

No description provided.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED

Comment 3

3 years ago
Comment on attachment 8744452 [details] [diff] [review]
Request names from the rootlist in JS::ubi::dumpPaths and clean up formatting of dumped paths

Review of attachment 8744452 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/UbiNodeShortestPaths.cpp
@@ +55,5 @@
> +
> +            auto typeName = backEdge->predecessor().typeName();
> +            auto len = js_strlen(typeName);
> +            for (size_t i = 0; i < len; i++)
> +                fprintf(stderr, "%c", char(typeName[i]));

This is too bad. Could you implement js_fputs in jsstr.{cpp,h}, and then call it here and below?

Also, you can always use fputwc in the implementation, not fprintf(..., "%c", ...), or fputc if casting char16_t to wchar_t is too gross.
Attachment #8744452 - Flags: review?(jimb) → review+
Attachment #8744452 - Attachment is obsolete: true

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/46d7944da816
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48

Comment 8

3 years ago
Comment on attachment 8744524 [details] [diff] [review]
Request names from the rootlist in JS::ubi::dumpPaths and clean up formatting of dumped paths

Review of attachment 8744524 [details] [diff] [review]:
-----------------------------------------------------------------

YAS
You need to log in before you can comment on or make changes to this bug.