Closed Bug 1266840 Opened 4 years ago Closed 4 years ago

replace use of nsIXMLHttpRequest

Categories

(DevTools :: Framework, enhancement, P1)

enhancement

Tracking

(firefox49 fixed)

RESOLVED FIXED
Firefox 49
Iteration:
49.2 - May 23
Tracking Status
firefox49 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file)

There's a use of nsIXMLHttpRequest in MdnDocsWidget.js.
This should be replaced for the devtools de-chrome-ification project.
Flags: qe-verify-
Priority: -- → P2
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
Comment on attachment 8751889 [details]
MozReview Request: Bug 1266840 - define XMLHttpRequest in devtools loader; r=jryans

https://reviewboard.mozilla.org/r/52271/#review49215

::: devtools/shared/builtin-modules.js:249
(Diff revision 1)
>      lazyRequireGetter: lazyRequireGetter,
>      id: null // Defined by Loader.jsm
>    },
> +
> +  // Let new XMLHttpRequest do the right thing.
> +  XMLHttpRequest: function (ignore) {

Why is this `ignore` here?
Attachment #8751889 - Flags: review?(jryans) → review+
Iteration: --- → 49.2 - May 23
Priority: P2 → P1
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #2)

> Why is this `ignore` here?

I can't wrap my head around ignoring the documented arity of a function.
I'll remove it.
Comment on attachment 8751889 [details]
MozReview Request: Bug 1266840 - define XMLHttpRequest in devtools loader; r=jryans

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52271/diff/1-2/
Attachment #8751889 - Attachment description: MozReview Request: Bug 1266840 - define XMLHttpRequest in devtools loader; r?jryans → MozReview Request: Bug 1266840 - define XMLHttpRequest in devtools loader; r=jryans
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/aeeab770eafe
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.