replace use of nsIXMLHttpRequest

RESOLVED FIXED in Firefox 49

Status

()

Firefox
Developer Tools: Framework
P1
enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tromey, Assigned: tromey)

Tracking

unspecified
Firefox 49
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: [devtools-html])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
There's a use of nsIXMLHttpRequest in MdnDocsWidget.js.
This should be replaced for the devtools de-chrome-ification project.

Updated

2 years ago
Flags: qe-verify-
Priority: -- → P2
(Assignee)

Updated

2 years ago
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
Created attachment 8751889 [details]
MozReview Request: Bug 1266840 - define XMLHttpRequest in devtools loader; r=jryans

Review commit: https://reviewboard.mozilla.org/r/52271/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52271/
Attachment #8751889 - Flags: review?(jryans)
Comment on attachment 8751889 [details]
MozReview Request: Bug 1266840 - define XMLHttpRequest in devtools loader; r=jryans

https://reviewboard.mozilla.org/r/52271/#review49215

::: devtools/shared/builtin-modules.js:249
(Diff revision 1)
>      lazyRequireGetter: lazyRequireGetter,
>      id: null // Defined by Loader.jsm
>    },
> +
> +  // Let new XMLHttpRequest do the right thing.
> +  XMLHttpRequest: function (ignore) {

Why is this `ignore` here?
Attachment #8751889 - Flags: review?(jryans) → review+

Updated

2 years ago
Iteration: --- → 49.2 - May 23
Priority: P2 → P1
(Assignee)

Comment 3

2 years ago
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #2)

> Why is this `ignore` here?

I can't wrap my head around ignoring the documented arity of a function.
I'll remove it.
(Assignee)

Comment 4

2 years ago
Comment on attachment 8751889 [details]
MozReview Request: Bug 1266840 - define XMLHttpRequest in devtools loader; r=jryans

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52271/diff/1-2/
Attachment #8751889 - Attachment description: MozReview Request: Bug 1266840 - define XMLHttpRequest in devtools loader; r?jryans → MozReview Request: Bug 1266840 - define XMLHttpRequest in devtools loader; r=jryans
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/aeeab770eafe
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.