1267005 - master password prompt shows more than once

Status: RESOLVED DUPLICATE of bug 1261021

(Toolkit :: Password Manager, defect)

Description

[[e-mail]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160423030220

Steps to reproduce:

I started Mozilla & it loaded recently viewed tabs, where were 2 tabs requiring login, so it showed me an master password prompt as usual, but in a moment (after 5 chars) there showed up another master password prompt stealing focus from the first one, so I typed half a password into first & a bit of second half into the second prompt.


Actual results:

Mozilla showed up two prompts for master password


Expected results:

It should show up only one prompt

Comment 2

[rugk]

This is ridiculous. Bug 1267005 is a duplicate of this bug and this bug is a duplicate of bug 1267005… Are you kidding?

This would not be bad if it have not caused this bug to be ignored for years. It is still reproducible in FF 53.0 and independent on add-ons or sites or OS version…
And it has been annoying me for years!

So here STR (tried on two completely different machines with FF 53.0):
1. Enable Firefox sync.
2. Enable/set a master password. (choose a properly long one)
3. Open a tab where you have a password saved (your mail provider etc.)
4. Pin this tab.
5. Restart Firefox.

What happens:
At startup the first master password box is shown. A few seconds later (regardless of whether you've already began typing in your password*) the second box is shown.

* which makes it worse as you start typing in your password in the one box and later continue the typing in the other half of the password in the second one…

Possible reason:
I assume the first box is for syncing the passwords/enabling Firefox sync as the credentials of Firefox sync are stored there, so Firefox needs to request the password directly when starting Firefox.
However, now the second password box is shown, because of the fact that 1) the password has not been entered yet (it is not available), but 2) Firefox wants to fill in the password into the pinned site, which is loading. For doing so FF need the master password and thus asks the user for it.
*However* it does not detect that the password box is already opened and thus shows it another time causing all this trouble for the user.

Both things can be confirmed when you leave out one thing, e.g. not enable sync or just do not pin a password-requiring website.

What should happen: Show input box once.

Possible solution:
Add a check, when opening the master password input modal, so that it checks whether there is already a modal opened and let it use this instead of opening a new one.

I am going to open a new bug if you are not willing to reopen this bug here…
This bug is horrible annoying…

Comment 3

[rugk]

Eh, forgot to change the bug numbers when copy/pasting, the first line must be bug 1261021 of course…

Comment 4

[slothy]

(In reply to rugk from comment #2)
> This is ridiculous. Bug 1267005 is a duplicate of this bug and this bug is a
> duplicate of bug 1267005… Are you kidding?
> 
> This would not be bad if it have not caused this bug to be ignored for
> years. It is still reproducible in FF 53.0 and independent on add-ons or
> sites or OS version…
> And it has been annoying me for years!
> 
> So here STR (tried on two completely different machines with FF 53.0):
> 1. Enable Firefox sync.
> 2. Enable/set a master password. (choose a properly long one)
> 3. Open a tab where you have a password saved (your mail provider etc.)
> 4. Pin this tab.
> 5. Restart Firefox.
> 
> What happens:
> At startup the first master password box is shown. A few seconds later
> (regardless of whether you've already began typing in your password*) the
> second box is shown.
> 
> * which makes it worse as you start typing in your password in the one box
> and later continue the typing in the other half of the password in the
> second one…
> 
> Possible reason:
> I assume the first box is for syncing the passwords/enabling Firefox sync as
> the credentials of Firefox sync are stored there, so Firefox needs to
> request the password directly when starting Firefox.
> However, now the second password box is shown, because of the fact that 1)
> the password has not been entered yet (it is not available), but 2) Firefox
> wants to fill in the password into the pinned site, which is loading. For
> doing so FF need the master password and thus asks the user for it.
> *However* it does not detect that the password box is already opened and
> thus shows it another time causing all this trouble for the user.
> 
> Both things can be confirmed when you leave out one thing, e.g. not enable
> sync or just do not pin a password-requiring website.
> 
> What should happen: Show input box once.
> 
> Possible solution:
> Add a check, when opening the master password input modal, so that it checks
> whether there is already a modal opened and let it use this instead of
> opening a new one.
> 
> I am going to open a new bug if you are not willing to reopen this bug here…
> This bug is horrible annoying…

Thank you rugk, this is exactly what I meant in my first report. It's super annoying and I still have to deal with it. It should be so easy to fix for somebody involved. :-/

Comment 5

[Albert Scheiner [:alberts]]

Reopening ... Sorry for the confusion and spam this has caused

Comment 6

[Wayne Mery (:wsmwk)]

Precisely how is this different from bug 1261021?

Comment 7

[Matthew N. [:MattN]]

This should be better now that Sync doesn't show a new prompt if one is already opened :)