Closed
Bug 1267017
Opened 8 years ago
Closed 8 years ago
Various Animation-related test_interfaces.html permafails when Gecko 48 merges to Beta
Categories
(Core :: DOM: Animation, defect)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox46 | --- | unaffected |
firefox47 | --- | unaffected |
firefox48 | + | fixed |
firefox49 | --- | fixed |
People
(Reporter: RyanVM, Assigned: hiro)
Details
Attachments
(1 file)
1.41 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
[Tracking Requested - why for this release]: Permafail when Gecko 48 merges to Beta. https://treeherder.mozilla.org/logviewer.html#?job_id=19895451&repo=try TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface Animation to all webpages as a property on the window (XBL: false)? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals) TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface Animation to all webpages as a property on the window (XBL: true)? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
Flags: needinfo?(hiikezoe)
Assignee | ||
Comment 1•8 years ago
|
||
I think Animation interface will be exposed based on bug 1245000 comment #33. Brian?
Flags: needinfo?(hiikezoe) → needinfo?(bbirtles)
Comment 2•8 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #1) > Created attachment 8744665 [details] [diff] [review] > Animation interface will be exposed on release channel > > I think Animation interface will be exposed based on bug 1245000 comment #33. > Brian? Yes, that's right.
Flags: needinfo?(bbirtles)
Reporter | ||
Comment 3•8 years ago
|
||
Were you going to request review on this, Hiro-san? :)
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8744665 [details] [diff] [review] Animation interface will be exposed on release channel Thank you, Ryan. Boris, we've been already shipping Animation interface, we need to expose it in the test as well.
Flags: needinfo?(hiikezoe)
Attachment #8744665 -
Flags: review?(bzbarsky)
Comment 5•8 years ago
|
||
Comment on attachment 8744665 [details] [diff] [review] Animation interface will be exposed on release channel r=me
Attachment #8744665 -
Flags: review?(bzbarsky) → review+
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7959d4dcff42
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Reporter | ||
Updated•8 years ago
|
Whiteboard: [checkin-needed-aurora]
Comment 8•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/8d5e742034ae
Whiteboard: [checkin-needed-aurora]
You need to log in
before you can comment on or make changes to this bug.
Description
•