1267095 - Correct small Javascript logic error in InputWidgetHelper

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Capella [:capella]]

This is a fairly simple bug for a new contributor with basic Javascript skills, to learn the Mozilla Mobile development process. Estimated completion time should be easily less than two weeks, and more likely less than one.

You should have an android device for testing your solution locally, and should be able to build Firefox Mobile on your desktop. See [0] for instructions if this is new to you, and ask questions on irc channels #introduction, or #mobile.

THE PROBLEM, is that while repeatedly long-pressing into the empty search field on the PAGE [1], on a tablet, I can observe the ERROR [2] in the LOGCAT.

(I didn't this try on a phone but expect it should fail there, too.)

This indicates a problem at this LINE [3] in this METHOD. Please identify it, and provide a solution.


[0] https://wiki.mozilla.org/Mobile/Fennec/Android

[1] https://duckduckgo.com/
[2] Error: "TypeError: aElement.getAttribute is not a function" {file: "chrome://browser/content/InputWidgetHelper.js" line: 69}]
[3] http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/InputWidgetHelper.js?rev=52a402b0f7bc&mark=65-65,69-69#65

Comment 1

[deepesh00]

I want to work on this bug . Please assign it to me .

Comment 2

[Siddharth Shah]

Hello, I am interested in working on this bug, can you help how should I proceed ahead?

Comment 3

[Mark Capella [:capella]]

For any interested contributors, the basic description in comment #0 above should be enough to solve for.

We don't usually assign bugs to someone until they can demonstrate a solution or sufficient understanding to be easily able to complete one.

So until then... if you're extremely new, you may need faster help in irc channel #introduction, as mentioned above. They'll push you to complete a first-build, start testing, and etc.

For Android specific questions in building / testing, irc channel #mobile is more specialized.

If you think you have a solution, tell us what you've done so far, and where you're stuck.

Comment 4

[Bhavin Dave (:bdave)]

Attachment: mylog.txt

Hi Mark,

I tried to simulate the issue after deploying the apk on my Nexus 5. However, the logcat generated does not contain the error message "TypeError: aElement.getAttribute is not a function".

Comment 5

[Bhavin Dave (:bdave)]

Attachment: newlog.txt

Here's another logcat captured after testing with same apk file on Galaxy Nexus emulator. Still no clue on the error message.

Comment 6

[Mark Capella [:capella]]

Yes, I can't repro this anymore either. DDG may have redesigned here a bit.