Put setting pref("browser.eme.ui.enabled" together

RESOLVED FIXED in Firefox 49

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: JamesCheng, Assigned: JamesCheng)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Could it be possible to put these [1],[2] together for better readability?
e.g.

#if defined(MOZ_ADOBE_EME) || defined(MOZ_WIDEVINE_EME)
pref("browser.eme.ui.enabled", true);
#else
pref("browser.eme.ui.enabled", false);
#endif


[1] https://dxr.mozilla.org/mozilla-central/rev/fc15477ce628599519cb0055f52cc195d640dc94/browser/app/profile/firefox.js#225

[2] https://dxr.mozilla.org/mozilla-central/rev/fc15477ce628599519cb0055f52cc195d640dc94/browser/app/profile/firefox.js#1378
(Assignee)

Comment 1

2 years ago
Created attachment 8744811 [details]
MozReview Request: Bug 1267139 - Put setting pref(browser.eme.ui.enabled together. r?cpearce

Review commit: https://reviewboard.mozilla.org/r/48687/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48687/
Attachment #8744811 - Flags: review?(cpearce)
Comment on attachment 8744811 [details]
MozReview Request: Bug 1267139 - Put setting pref(browser.eme.ui.enabled together. r?cpearce

https://reviewboard.mozilla.org/r/48687/#review45643
Attachment #8744811 - Flags: review?(cpearce) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f377541fc3af
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.