1267167 - New tabs are opened only in Firefox Beta via Today's Widget

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Simon Basca [:SimonB]]

Build: 4.0.0b3
Build: 5.0.0(1)

Steps to reproduce:
1. Install Firefox beta and nightly
2. Add both version to Today's Widget menu
3. Open Today's Widget menu 
4. Open new tab from Firefox Beta
5. Open new tab From Firefox Nightly

Actual results:
- The new tabs opened via Today's Widget from both Firefox versions are opened only in Firefox Beta.

Expected results:
- The new tab opened via Today's Widget should be opened in the corresponding Firefox version.

Comment 1

[Aaron Train [:aaronmt]]

This is more than likely WONTFIX, as firefox:// is the registered context for opening the application for both applications and we're not likely to change this. The order of precedence is probably the install order.

Comment 2

[James Hugman [:jhugman] [@jhugman]]

While this is possible, in a similar way to the way we provide build specific AdjustAppToken, this would break any apps that use the 'Open in Firefox' library when a release version of Firefox is not installed.

It may be worth separating out internal and external users of the scheme, such that the external usage /always/ uses the firefox:// scheme (and thus the open in firefox apps won't break), but internal use routes to the correct version of the app.

Renomming for target.next.

Comment 3

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1876

Comment 4

[Emily Toop (:fluffyemily)]

Comment on attachment 8758897 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1876

Just a small nit

Comment 5

[James Hugman [:jhugman] [@jhugman]]

Thanks, fluffyemily!

Addressed nits, and merged.

Comment 6

[Stephan Leroux [:sleroux]]

Does this need uplift?

Comment 7

[James Hugman [:jhugman] [@jhugman]]

YES!

Comment 8

[Stephan Leroux [:sleroux]]

v5.x 7a215a2

Comment 9

[Simon Basca [:SimonB]]

Verifying as fixed on master 6ad4b686.