Closed Bug 1267180 Opened 6 years ago Closed 6 years ago
Apple Color Emoji font fails to display at large sizes when using Skia content rendering
When using Skia content rendering, emoji characters in the Apple Color Emoji font fail to display over a certain size (128px on retina, 256px on non-retina), when using the CoreGraphics backend they show correctly. In the attached file there should be 4 emoji characters showing, the top row has 2 characters straddling the 128/129px boundary, the bottom row 256/257px. On my retina display only the top left one displays. If I zoom out to 50% then both characters on the top row show, but only the left most one on the bottom row shows.
I didn't realize Bugzilla actually forced windows-1252, this should work.
Attachment #8744850 - Attachment is obsolete: true
Status: UNCONFIRMED → NEW
Ever confirmed: true
This is because Skia doesn't render some fonts if they are too big. The failure also occurs in Chrome, but not Safari.
Big fonts will be rendered as paths, and Skia would try to get the path from CG , which would return null, so we'd render nothing. This patch tells Skia to draw the glyph as a normal glyph and not a path if it has color glyphs. Also a good possible candidate for upstream as chrome fails too.  https://dxr.mozilla.org/mozilla-central/source/gfx/skia/skia/src/core/SkDraw.cpp?case=true&from=SkDraw.cpp#1412  https://dxr.mozilla.org/mozilla-central/source/gfx/skia/skia/src/ports/SkFontHost_mac.cpp?from=SkFontHost_mac.cpp#1393
Attachment #8746638 - Flags: review?(lsalzman)
Attachment #8746638 - Flags: review?(lsalzman) → review+
Try looks good - https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e3895576d96
You need to log in before you can comment on or make changes to this bug.