1267214 - Private DBus connections must be closed before final unref

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Private connection over DBus must be closed by the caller. We can do that automatically with |UniquePtr|.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1276214: Add |DBusConnectionDelete| for using |DBusConnection| with |UniquePtr|

Hi Shawn,

with this type |UniquePtr| can manage instances of |DBusConnection|.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1267214: Close private DBus connection in |nsDBusHandlerApp::LaunchWithURI|

This is a follow-up patch to bug 1266033. It makes sure that the DBus connection is closed correctly before the data structure goes out of scope. Have a look at bug 1266705 comment 2 and below for some context.

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #2)
> Created attachment 8744868 [details] [diff] [review]
> [02] Bug 1267214: Close private DBus connection in
> |nsDBusHandlerApp::LaunchWithURI|
> 
> This is a follow-up patch to bug 1266033. It makes sure that the DBus
> connection is closed correctly before the data structure goes out of scope.
> Have a look at bug 1266705 comment 2 and below for some context.

Is there an easy way of testing this?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8744868 [details] [diff] [review]
[02] Bug 1267214: Close private DBus connection in |nsDBusHandlerApp::LaunchWithURI|

r=me

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/58318cd3faec
https://hg.mozilla.org/integration/mozilla-inbound/rev/b97e26486559

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thank you!

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b97e26486559

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/58318cd3faec
https://hg.mozilla.org/mozilla-central/rev/b97e26486559