1267241 - Incorrect position of copy link in Today's Widget menu

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Simon Basca [:SimonB]]

Attachment: Screenshot of the issue.PNG

Build: 4.0.0b3

Steps to reproduce:
1. Launch Firefox
2. Open a new tab and go to amazon.com
3. Copy the URL
4. Rotate device in landscape view
5. Swipe down to open Today's Widget menu

Actual results:
- The copied URL is not vertically aligned with the content

Expected results:
- The content should be vertically aligned

Note:
- This issue occurs only on IPhone 6, 6S, 6 Plus in landscape view

Comment 1

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1839

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Steph – you said you might have some insight?

Comment 3

[Stephan Leroux [:sleroux]]

I was just going to mention the default padding [1] but it looks like you've compensated for it in the PR. Nevermind!

[1] https://developer.apple.com/library/ios/documentation/NotificationCenter/Reference/NCWidgetProviding_Protocol/#//apple_ref/occ/intfm/NCWidgetProviding/widgetMarginInsetsForProposedMarginInsets:

Comment 4

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8754883 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1839

We should land this before 5.0.

It's a good deal better than it was, but not perfect.

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8754883 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1839

LGTM. Tested on 6+

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

https://github.com/mozilla/firefox-ios/commit/6e972f6c0306fffe50e46189c6904598dacc042a

Comment 7

[Stephan Leroux [:sleroux]]

v5.x 6e972f6c0306fffe50e46189c6904598dacc042a

Comment 8

[Simon Basca [:SimonB]]

Tested on 5.0b10
The copied link is correctly positioned.