1267246 - OSX debug e10s mochitest perma-asserts since bug 1264161 landed (Assertion failure: mUsedShmems.empty(), at gfx/layers/ipc/ShadowLayers.cpp:221)

Reporter

Description

•

8 years ago

I'm assuming this is a regression from bug 1264161. This breaks a lot of OSX debug tests, so I think this needs more concern/tracking than the usual e10s-tests treatment.

https://treeherder.mozilla.org/logviewer.html#?job_id=170574&repo=ash

05:53:22     INFO -  Assertion failure: mUsedShmems.empty(), at /builds/slave/ash-m64-d-00000000000000000000/build/src/gfx/layers/ipc/ShadowLayers.cpp:221
05:53:51     INFO -  #01: mozilla::layers::ShadowLayerForwarder::~ShadowLayerForwarder() [memory/mozalloc/mozalloc.h:210]
05:53:51     INFO -  #02: mozilla::AtomicRefCountedWithFinalize<mozilla::layers::ISurfaceAllocator>::Release() [gfx/layers/AtomicRefCountedWithFinalize.h:166]
05:53:51     INFO -  #03: mozilla::layers::TextureChild::~TextureChild() [gfx/layers/IPDLActor.h:43]
05:53:51     INFO -  #04: mozilla::layers::TextureChild::~TextureChild() [memory/mozalloc/mozalloc.h:210]
05:53:51     INFO -  #05: mozilla::layers::TextureChild::Release() [gfx/layers/client/TextureClient.cpp:96]
05:53:51     INFO -  #06: mozilla::layers::TextureClient::DestroyIPDLActor(mozilla::layers::PTextureChild*) [gfx/layers/client/TextureClient.cpp:589]
05:53:51     INFO -  #07: mozilla::layers::PTextureChild::OnMessageReceived(IPC::Message const&) [obj-firefox/ipc/ipdl/PTextureChild.cpp:245]
05:53:51     INFO -  #08: mozilla::layers::PCompositorBridgeChild::OnMessageReceived(IPC::Message const&) [obj-firefox/ipc/ipdl/PCompositorBridgeChild.cpp:922]
05:53:51     INFO -  #09: mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&) [ipc/glue/MessageChannel.h:542]
05:53:51     INFO -  #10: mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message const&) [ipc/glue/MessageChannel.cpp:1585]
05:53:51     INFO -  #11: mozilla::ipc::MessageChannel::OnMaybeDequeueOne() [ipc/glue/MessageChannel.cpp:1552]
05:53:51     INFO -  #12: MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const&) [ipc/chromium/src/base/message_loop.cc:350]
05:53:51     INFO -  #13: MessageLoop::DoWork() [ipc/chromium/src/base/message_loop.cc:444]
05:53:51     INFO -  #14: mozilla::ipc::DoWorkRunnable::Run() [ipc/glue/MessagePump.cpp:228]
05:53:51     INFO -  #15: nsThread::ProcessNextEvent(bool, bool*) [xpcom/glue/nsCOMPtr.h:403]
05:53:51     INFO -  #16: NS_ProcessPendingEvents(nsIThread*, unsigned int) [xpcom/glue/nsThreadUtils.cpp:232]
05:53:51     INFO -  #17: nsBaseAppShell::NativeEventCallback() [widget/nsBaseAppShell.cpp:98]
05:53:51     INFO -  #18: nsAppShell::ProcessGeckoEvents(void*) [widget/cocoa/nsAppShell.mm:388]
05:53:51     INFO -  #19: CoreFoundation + 0x80a01
05:53:51     INFO -  #20: CoreFoundation + 0x72b8d
05:53:51     INFO -  #21: CoreFoundation + 0x721bf
05:53:51     INFO -  #22: CoreFoundation + 0x71bd8
05:53:51     INFO -  #23: HIToolbox + 0x3256f
05:53:51     INFO -  #24: HIToolbox + 0x322ea
05:53:51     INFO -  #25: HIToolbox + 0x3212b
05:53:51     INFO -  #26: AppKit + 0x918ab
05:53:51     INFO -  #27: AppKit + 0x90e58
05:53:51     INFO -  #28: -[GeckoNSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] [widget/cocoa/nsAppShell.mm:121]
05:53:51     INFO -  #29: AppKit + 0x86af3
05:53:51     INFO -  #30: nsAppShell::Run() [xpcom/glue/nsCOMPtr.h:536]
05:53:51     INFO -  #31: XRE_RunAppShell [toolkit/xre/nsEmbedFunctions.cpp:801]
05:53:51     INFO -  #32: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:271]
05:53:51     INFO -  #33: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:505]
05:53:51     INFO -  #34: XRE_InitChildProcess [xpcom/base/nsAutoPtr.h:199]
05:53:51     INFO -  #35: content_process_main(int, char**) [ipc/contentproc/plugin-container.cpp:237]

05:54:03  WARNING -  PROCESS-CRASH | Main app process exited normally | application crashed [@ mozilla::layers::FixedSizeSmallShmemSectionAllocator::~FixedSizeSmallShmemSectionAllocator()]
05:54:03     INFO -  Crash dump filename: /var/folders/0k/x84zh_fj74941yslkv8b5zhm00000w/T/tmpECtLav.mozrunner/minidumps/EE3D5877-7EFA-4695-8F99-F9848D5DB0F0.dmp
05:54:03     INFO -  Operating system: Mac OS X
05:54:03     INFO -                    10.10.5 14F27
05:54:03     INFO -  CPU: amd64
05:54:03     INFO -       family 6 model 69 stepping 1
05:54:03     INFO -       4 CPUs
05:54:03     INFO -  Crash reason:  EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
05:54:03     INFO -  Crash address: 0x0
05:54:03     INFO -  Process uptime: 17 seconds
05:54:03     INFO -  Thread 0 (crashed)
05:54:03     INFO -   0  XUL!mozilla::layers::FixedSizeSmallShmemSectionAllocator::~FixedSizeSmallShmemSectionAllocator() [ShadowLayers.cpp:1c6385ae1fe7 : 221 + 0x0]
05:54:03     INFO -      rax = 0x0000000000000000   rdx = 0x00007fff7473a1f8
05:54:03     INFO -      rcx = 0x0000000000000000   rbx = 0x00007fff7473ac50
05:54:03     INFO -      rsi = 0x0000810000008100   rdi = 0x0000000105096099
05:54:03     INFO -      rbp = 0x00007fff5fbfb7d0   rsp = 0x00007fff5fbfb7c0
05:54:03     INFO -       r8 = 0x00007fff5fbfb770    r9 = 0x00007fff7429b300
05:54:03     INFO -      r10 = 0x0000000100000c90   r11 = 0x0000000100000c50
05:54:03     INFO -      r12 = 0x0000000112baf270   r13 = 0x00007fff5fbfbed8
05:54:03     INFO -      r14 = 0x000000011b8d6980   r15 = 0x000000011b8d6980
05:54:03     INFO -      rip = 0x00000001013a168d
05:54:03     INFO -      Found by: given as instruction pointer in context
05:54:03     INFO -   1  XUL!mozilla::layers::ShadowLayerForwarder::~ShadowLayerForwarder() [ShadowLayers.cpp:1c6385ae1fe7 : 218 + 0x8]
05:54:03     INFO -      rbx = 0x00000001128e6970   rbp = 0x00007fff5fbfb800
05:54:03     INFO -      rsp = 0x00007fff5fbfb7e0   r12 = 0x0000000112baf270
05:54:03     INFO -      r13 = 0x00007fff5fbfbed8   r14 = 0x000000011b8d6980
05:54:03     INFO -      r15 = 0x000000011b8d6980   rip = 0x00000001013a23e0
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -   2  XUL!mozilla::layers::ShadowLayerForwarder::~ShadowLayerForwarder() [ShadowLayers.cpp:1c6385ae1fe7 : 380 + 0x5]
05:54:03     INFO -      rbx = 0x000000011b8d6980   rbp = 0x00007fff5fbfb820
05:54:03     INFO -      rsp = 0x00007fff5fbfb810   r12 = 0x0000000112baf270
05:54:03     INFO -      r13 = 0x00007fff5fbfbed8   r14 = 0x000000011b8d6980
05:54:03     INFO -      r15 = 0x000000011b8d6998   rip = 0x00000001013a277e
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -   3  XUL!mozilla::AtomicRefCountedWithFinalize<mozilla::layers::ISurfaceAllocator>::Release() [AtomicRefCountedWithFinalize.h:1c6385ae1fe7 : 148 + 0xe]
05:54:03     INFO -      rbx = 0x000000011b8d6988   rbp = 0x00007fff5fbfbb70
05:54:03     INFO -      rsp = 0x00007fff5fbfb830   r12 = 0x0000000112baf270
05:54:03     INFO -      r13 = 0x00007fff5fbfbed8   r14 = 0x000000011b8d6980
05:54:03     INFO -      r15 = 0x000000011b8d6998   rip = 0x0000000101293e96
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -   4  XUL!mozilla::layers::TextureChild::~TextureChild() [RefPtr.h:1c6385ae1fe7 : 39 + 0x9]
05:54:03     INFO -      rbx = 0x0000000112baf270   rbp = 0x00007fff5fbfbb90
05:54:03     INFO -      rsp = 0x00007fff5fbfbb80   r12 = 0x0000000112baf270
05:54:03     INFO -      r13 = 0x00007fff5fbfbed8   r14 = 0x0000000112baf270
05:54:03     INFO -      r15 = 0x00007fff5fbfbee0   rip = 0x00000001013662b5
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -   5  XUL!mozilla::layers::TextureChild::~TextureChild() [TextureClient.cpp:1c6385ae1fe7 : 91 + 0x5]
05:54:03     INFO -      rbx = 0x0000000112baf270   rbp = 0x00007fff5fbfbbb0
05:54:03     INFO -      rsp = 0x00007fff5fbfbba0   r12 = 0x0000000112baf270
05:54:03     INFO -      r13 = 0x00007fff5fbfbed8   r14 = 0x0000000112baf270
05:54:03     INFO -      r15 = 0x00007fff5fbfbee0   rip = 0x0000000101361a3e
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -   6  XUL!mozilla::layers::TextureChild::Release() [TextureClient.cpp:1c6385ae1fe7 : 96 + 0x9]
05:54:03     INFO -      rbx = 0x0000000000000000   rbp = 0x00007fff5fbfbbd0
05:54:03     INFO -      rsp = 0x00007fff5fbfbbc0   r12 = 0x0000000112baf270
05:54:03     INFO -      r13 = 0x00007fff5fbfbed8   r14 = 0x0000000112baf270
05:54:03     INFO -      r15 = 0x00007fff5fbfbee0   rip = 0x0000000101362ee9
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -   7  XUL!mozilla::layers::TextureClient::DestroyIPDLActor(mozilla::layers::PTextureChild*) [TextureClient.cpp:1c6385ae1fe7 : 160 + 0x5]
05:54:03     INFO -      rbx = 0x0000000000000000   rbp = 0x00007fff5fbfbbf0
05:54:03     INFO -      rsp = 0x00007fff5fbfbbe0   r12 = 0x0000000112baf270
05:54:03     INFO -      r13 = 0x00007fff5fbfbed8   r14 = 0x0000000112baf270
05:54:03     INFO -      r15 = 0x00007fff5fbfbee0   rip = 0x000000010133956e
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -   8  XUL!mozilla::layers::PTextureChild::OnMessageReceived(IPC::Message const&) [PTextureChild.cpp:1c6385ae1fe7 : 245 + 0xe]
05:54:03     INFO -      rbx = 0x0000000000000000   rbp = 0x00007fff5fbfbc70
05:54:03     INFO -      rsp = 0x00007fff5fbfbc00   r12 = 0x0000000112baf270
05:54:03     INFO -      r13 = 0x00007fff5fbfbed8   r14 = 0x0000000112baf270
05:54:03     INFO -      r15 = 0x00007fff5fbfbee0   rip = 0x0000000100c882cb
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -   9  XUL!mozilla::layers::PCompositorBridgeChild::OnMessageReceived(IPC::Message const&) [PCompositorBridgeChild.cpp:1c6385ae1fe7 : 922 + 0xc]
05:54:03     INFO -      rbx = 0x0000000000000006   rbp = 0x00007fff5fbfbd60
05:54:03     INFO -      rsp = 0x00007fff5fbfbc80   r12 = 0x00007fff5fbfbed8
05:54:03     INFO -      r13 = 0x0000000000000000   r14 = 0x000000011afa2400
05:54:03     INFO -      r15 = 0x00007fff5fbfbee0   rip = 0x0000000100d62521
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  10  XUL!mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&) [MessageChannel.cpp:1c6385ae1fe7 : 1647 + 0x9]
05:54:03     INFO -      rbx = 0x0000000000000001   rbp = 0x00007fff5fbfbdc0
05:54:03     INFO -      rsp = 0x00007fff5fbfbd70   r12 = 0x000000011afa2468
05:54:03     INFO -      r13 = 0x0000000000000000   r14 = 0x00007fff5fbfbed8
05:54:03     INFO -      r15 = 0x00000000ffffff00   rip = 0x0000000100a67360
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  11  XUL!mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message const&) [MessageChannel.cpp:1c6385ae1fe7 : 1585 + 0xb]
05:54:03     INFO -      rbx = 0x000000011aff88d0   rbp = 0x00007fff5fbfbec0
05:54:03     INFO -      rsp = 0x00007fff5fbfbdd0   r12 = 0x00007fff5fbfbed8
05:54:03     INFO -      r13 = 0xb700b6a4bc135622   r14 = 0x000000011afa2468
05:54:03     INFO -      r15 = 0x00000000ffffffff   rip = 0x0000000100a65aa9
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  12  XUL!mozilla::ipc::MessageChannel::OnMaybeDequeueOne() [MessageChannel.cpp:1c6385ae1fe7 : 1552 + 0x8]
05:54:03     INFO -      rbx = 0x0000000000000001   rbp = 0x00007fff5fbfbf40
05:54:03     INFO -      rsp = 0x00007fff5fbfbed0   r12 = 0x0000000000000000
05:54:03     INFO -      r13 = 0x0000000000000000   r14 = 0x000000011aff88d0
05:54:03     INFO -      r15 = 0x000000011afa2468   rip = 0x0000000100a5da99
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  13  XUL!MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const&) [message_loop.cc:1c6385ae1fe7 : 349 + 0x9]
05:54:03     INFO -      rbx = 0x000000011223a640   rbp = 0x00007fff5fbfbf90
05:54:03     INFO -      rsp = 0x00007fff5fbfbf50   r12 = 0x0000000000000000
05:54:03     INFO -      r13 = 0x0000000000000000   r14 = 0x00007fff5fbfebc8
05:54:03     INFO -      r15 = 0xb700b6a4bc135622   rip = 0x0000000100a2bc0c
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  14  XUL!MessageLoop::DoWork() [message_loop.cc:1c6385ae1fe7 : 444 + 0xb]
05:54:03     INFO -      rbx = 0x00007fff5fbfebc8   rbp = 0x00007fff5fbfbfd0
05:54:03     INFO -      rsp = 0x00007fff5fbfbfa0   r12 = 0x0000000000000000
05:54:03     INFO -      r13 = 0x0000000000000000   r14 = 0x00007fff5fbfbfa8
05:54:03     INFO -      r15 = 0x00007fff5fbfbfa0   rip = 0x0000000100a2bf5b
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  15  XUL!mozilla::ipc::DoWorkRunnable::Run() [MessagePump.cpp:1c6385ae1fe7 : 227 + 0x9]
05:54:03     INFO -      rbx = 0x00007fff5fbfebc8   rbp = 0x00007fff5fbfbff0
05:54:03     INFO -      rsp = 0x00007fff5fbfbfe0   r12 = 0x0000000000000000
05:54:03     INFO -      r13 = 0x0000000000000000   r14 = 0x0000000106f1d001
05:54:03     INFO -      r15 = 0x00007fff5fbfc030   rip = 0x0000000100a6b875
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  16  XUL!nsThread::ProcessNextEvent(bool, bool*) [nsThread.cpp:1c6385ae1fe7 : 994 + 0x6]
05:54:03     INFO -      rbx = 0x0000000106fc1200   rbp = 0x00007fff5fbfc090
05:54:03     INFO -      rsp = 0x00007fff5fbfc000   r12 = 0x0000000000000000
05:54:03     INFO -      r13 = 0x0000000000000000   r14 = 0x0000000106f1d000
05:54:03     INFO -      r15 = 0x00007fff5fbfc030   rip = 0x00000001004f7d40
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  17  XUL!NS_ProcessPendingEvents(nsIThread*, unsigned int) [nsThreadUtils.cpp:1c6385ae1fe7 : 232 + 0xf]
05:54:03     INFO -      rbx = 0x0000000000000000   rbp = 0x00007fff5fbfc0d0
05:54:03     INFO -      rsp = 0x00007fff5fbfc0a0   r12 = 0x00007fff5fbfc0a7
05:54:03     INFO -      r13 = 0x0000000106fc1200   r14 = 0x000000000000000a
05:54:03     INFO -      r15 = 0x0000000000092a7a   rip = 0x0000000100537c9f
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  18  XUL!nsBaseAppShell::NativeEventCallback() [nsBaseAppShell.cpp:1c6385ae1fe7 : 97 + 0xa]
05:54:03     INFO -      rbx = 0x00000001126a0b80   rbp = 0x00007fff5fbfc100
05:54:03     INFO -      rsp = 0x00007fff5fbfc0e0   r12 = 0x0000000000000000
05:54:03     INFO -      r13 = 0x0000000000002e07   r14 = 0x0000000106fc1200
05:54:03     INFO -      r15 = 0x00000001126a0b00   rip = 0x0000000102f3a4f4
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  19  XUL!nsAppShell::ProcessGeckoEvents(void*) [nsAppShell.mm:1c6385ae1fe7 : 387 + 0x8]
05:54:03     INFO -      rbx = 0x0000000106c00de0   rbp = 0x00007fff5fbfc150
05:54:03     INFO -      rsp = 0x00007fff5fbfc110   r12 = 0x0000000106b55180
05:54:03     INFO -      r13 = 0x0000000000002e07   r14 = 0x0000000106f91000
05:54:03     INFO -      r15 = 0x00000001126a0b80   rip = 0x0000000102fa4fd5
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  20  CoreFoundation!__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 0x11
05:54:03     INFO -      rbx = 0x0000000106c00de0   rbp = 0x00007fff5fbfc160
05:54:03     INFO -      rsp = 0x00007fff5fbfc160   r12 = 0x0000000106b55180
05:54:03     INFO -      r13 = 0x0000000000002e07   r14 = 0x0000000106b55198
05:54:03     INFO -      r15 = 0x0000000106c00c88   rip = 0x00007fff9206ca01
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  21  CoreFoundation!__CFRunLoopDoSources0 + 0x10d
05:54:03     INFO -      rbp = 0x00007fff5fbfc1c0   rsp = 0x00007fff5fbfc170
05:54:03     INFO -      rip = 0x00007fff9205eb8d
05:54:03     INFO -      Found by: previous frame's frame pointer
05:54:03     INFO -  22  CoreFoundation!__CFRunLoopRun + 0x39f
05:54:03     INFO -      rbp = 0x00007fff5fbfcea0   rsp = 0x00007fff5fbfc1d0
05:54:03     INFO -      rip = 0x00007fff9205e1bf
05:54:03     INFO -      Found by: previous frame's frame pointer
05:54:03     INFO -  23  CoreFoundation!CFRunLoopRunSpecific + 0x128
05:54:03     INFO -      rbp = 0x00007fff5fbfcf00   rsp = 0x00007fff5fbfceb0
05:54:03     INFO -      rip = 0x00007fff9205dbd8
05:54:03     INFO -      Found by: previous frame's frame pointer
05:54:03     INFO -  24  HIToolbox!RunCurrentEventLoopInMode + 0xeb
05:54:03     INFO -      rbp = 0x00007fff5fbfcf40   rsp = 0x00007fff5fbfcf10
05:54:03     INFO -      rip = 0x00007fff9000256f
05:54:03     INFO -      Found by: previous frame's frame pointer
05:54:03     INFO -  25  HIToolbox!ReceiveNextEventCommon + 0x1af
05:54:03     INFO -      rbp = 0x00007fff5fbfcfc0   rsp = 0x00007fff5fbfcf50
05:54:03     INFO -      rip = 0x00007fff900022ea
05:54:03     INFO -      Found by: previous frame's frame pointer
05:54:03     INFO -  26  HIToolbox!_BlockUntilNextEventMatchingListInModeWithFilter + 0x47
05:54:03     INFO -      rbp = 0x00007fff5fbfcfe0   rsp = 0x00007fff5fbfcfd0
05:54:03     INFO -      rip = 0x00007fff9000212b
05:54:03     INFO -      Found by: previous frame's frame pointer
05:54:03     INFO -  27  AppKit!_DPSNextEvent + 0x3d2
05:54:03     INFO -      rbp = 0x00007fff5fbfd450   rsp = 0x00007fff5fbfcff0
05:54:03     INFO -      rip = 0x00007fff868888ab
05:54:03     INFO -      Found by: previous frame's frame pointer
05:54:03     INFO -  28  AppKit!-[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 0x15a
05:54:03     INFO -      rbp = 0x00007fff5fbfd6f0   rsp = 0x00007fff5fbfd460
05:54:03     INFO -      rip = 0x00007fff86887e58
05:54:03     INFO -      Found by: previous frame's frame pointer
05:54:03     INFO -  29  XUL!-[GeckoNSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] [nsAppShell.mm:1c6385ae1fe7 : 121 + 0x2c]
05:54:03     INFO -      rbp = 0x00007fff5fbfd740   rsp = 0x00007fff5fbfd700
05:54:03     INFO -      rip = 0x0000000102fa4296
05:54:03     INFO -      Found by: previous frame's frame pointer
05:54:03     INFO -  30  AppKit!-[NSApplication run] + 0x252
05:54:03     INFO -      rbx = 0x000000011c10bc40   rbp = 0x00007fff5fbfd7c0
05:54:03     INFO -      rsp = 0x00007fff5fbfd750   r12 = 0x0000000000000000
05:54:03     INFO -      r13 = 0x0000000112b6a370   r14 = 0x0000000112b6a370
05:54:03     INFO -      r15 = 0x0000000108000001   rip = 0x00007fff8687daf3
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  31  XUL!nsAppShell::Run() [nsAppShell.mm:1c6385ae1fe7 : 661 + 0x17]
05:54:03     INFO -      rbp = 0x00007fff5fbfd810   rsp = 0x00007fff5fbfd7d0
05:54:03     INFO -      rip = 0x0000000102fa5755
05:54:03     INFO -      Found by: previous frame's frame pointer
05:54:03     INFO -  32  XUL!XRE_RunAppShell [nsEmbedFunctions.cpp:1c6385ae1fe7 : 801 + 0x6]
05:54:03     INFO -      rbx = 0x0000000113dd6d40   rbp = 0x00007fff5fbfd870
05:54:03     INFO -      rsp = 0x00007fff5fbfd820   r14 = 0x0000000106f06a01
05:54:03     INFO -      r15 = 0x00007fff5fbfebc8   rip = 0x0000000103c39571
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  33  XUL!mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) [MessagePump.cpp:1c6385ae1fe7 : 271 + 0x5]
05:54:03     INFO -      rbx = 0x00007fff5fbfebc8   rbp = 0x00007fff5fbfd8a0
05:54:03     INFO -      rsp = 0x00007fff5fbfd880   r14 = 0x0000000106f06a60
05:54:03     INFO -      r15 = 0x0000000000000000   rip = 0x0000000100a6ba37
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  34  XUL!MessageLoop::Run() [message_loop.cc:1c6385ae1fe7 : 223 + 0x5]
05:54:03     INFO -      rbx = 0x0000000000000010   rbp = 0x00007fff5fbfd8d0
05:54:03     INFO -      rsp = 0x00007fff5fbfd8b0   r12 = 0x0000000106f341f0
05:54:03     INFO -      r14 = 0x0000000106f8c000   r15 = 0x0000000000000000
05:54:03     INFO -      rip = 0x0000000100a2b3ec
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  35  XUL!XRE_InitChildProcess [nsEmbedFunctions.cpp:1c6385ae1fe7 : 637 + 0x5]
05:54:03     INFO -      rbx = 0x0000000000000010   rbp = 0x00007fff5fbfee40
05:54:03     INFO -      rsp = 0x00007fff5fbfd8e0   r12 = 0x0000000106f341f0
05:54:03     INFO -      r14 = 0x0000000106f8c000   r15 = 0x0000000000000000
05:54:03     INFO -      rip = 0x0000000103c38ef5
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  36  plugin-container!content_process_main(int, char**) [plugin-container.cpp:1c6385ae1fe7 : 237 + 0xe]
05:54:03     INFO -      rbx = 0x0000000106f069c0   rbp = 0x00007fff5fbfee80
05:54:03     INFO -      rsp = 0x00007fff5fbfee50   r12 = 0x000000000000000a
05:54:03     INFO -      r13 = 0x0000000000000000   r14 = 0x0000000000000000
05:54:03     INFO -      r15 = 0x00007fff5fbfeea0   rip = 0x0000000100003e66
05:54:03     INFO -      Found by: call frame info
05:54:03     INFO -  37  plugin-container!start + 0x34
05:54:03     INFO -      rbx = 0x0000000000000000   rbp = 0x00007fff5fbfee90
05:54:03     INFO -      rsp = 0x00007fff5fbfee90   r12 = 0x0000000000000000
05:54:03     INFO -      r13 = 0x0000000000000000   r14 = 0x0000000000000000
05:54:03     INFO -      r15 = 0x0000000000000000   rip = 0x0000000100000c84
05:54:03     INFO -      Found by: call frame info

Flags: needinfo?(bugmail.mozilla)

Kartikaya Gupta (email:kats@mozilla.staktrace.com)

Assignee

Comment 1

•

8 years ago

Nical, this assertion started firing after I landed a memory leak fix. Previously with APZ opening and closing a window would leak the layermanager/compositor/widget until browser ahutdown. Now that is fixed but this assertion is firing. I was seeing this assertion in the M-e10s(bc*) tests in an earlier version of my patch (bug 1264161 comment 26) but I changed the patch to avoid it and landed that. Turns out the same failure is happening on ash. Any ideas on how to chase it down?

Flags: needinfo?(bugmail.mozilla) → needinfo?(nical.bugzilla)

Nicolas Silva [:nical]

Comment 2

•

8 years ago

(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #1)
> Nical, this assertion started firing after I landed a memory leak fix.
> Previously with APZ opening and closing a window would leak the
> layermanager/compositor/widget until browser ahutdown. Now that is fixed but
> this assertion is firing. I was seeing this assertion in the M-e10s(bc*)
> tests in an earlier version of my patch (bug 1264161 comment 26) but I
> changed the patch to avoid it and landed that. Turns out the same failure is
> happening on ash. Any ideas on how to chase it down?

I also ran into this recently, and my conclusion was that the ShadowLayerForwarder's FixedSizeShmemSectionAllocator is destroyed before the parent has had time to acknowledge the destruction of all of the tiled layers. As a result some of the tiles' copy-on-write locks haven't been "unlocked"by the time the ShmemSectionAllocator that they rely on dies. It's not clear how to fix this elegantly. Basically we would need the FixedSizeShmemSectionAllocator to be deleted at the end of CompositorBridgeChild or LayerTransactionChild's destruction to be sure the layers have been cleaned up, but this ShmemSectionAllocator is currently put as an implementation detail of ShadowLayerForwarder which is desotroyed before LayerTransactionChild through the magics of reference counting.

As it stands the assertion is not strictly correct (it would be correct if it was happening later), so we can also just remove it. That will mean we don't have a way to check that the tile ReadLock/ReadUnlock are balanced correctly (better have no check than a bogus check...).

Flags: needinfo?(nical.bugzilla)

Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)

Updated

•

8 years ago

Comment 3

•

8 years ago

Attached file MozReview Request: Bug 1267246 - Remove bogus assertion. r?nical — Details

Review commit: https://reviewboard.mozilla.org/r/49011/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49011/

Attachment #8745367 - Flags: review?(nical.bugzilla)

Kartikaya Gupta (email:kats@mozilla.staktrace.com)

Assignee

Comment 4

•

8 years ago

Not sure why 47 is marked as affected; for now we have no evidence that is affected. It may be affected after bug 1264161 gets uplifted.

Assignee: nobody → bugmail.mozilla

status-firefox47: affected → ?

status-firefox49: --- → affected

Kartikaya Gupta (email:kats@mozilla.staktrace.com)

Assignee

Updated

•

8 years ago

Comment 6

•

8 years ago

Yeah, that was preemptive on my part assuming bug 1264161 was going to be uplifted there.

Nicolas Silva [:nical]

Comment 7

•

8 years ago

Comment on attachment 8745367 [details]
MozReview Request: Bug 1267246 - Remove bogus assertion. r?nical

https://reviewboard.mozilla.org/r/49011/#review45815

Attachment #8745367 - Flags: review?(nical.bugzilla) → review+

Kartikaya Gupta (email:kats@mozilla.staktrace.com)

Assignee

Comment 8

•

8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/19b738760bcab207a2054faaffdbded54e79a82d

Jim Mathies [:jimm]

Updated

•

8 years ago

Blocks: e10s-tests

tracking-e10s: ? → +

Carsten Book [:Tomcat]

Comment 9

•

8 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/19b738760bca

Status: NEW → RESOLVED

Closed: 8 years ago

status-firefox49: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla48

Carsten Book [:Tomcat]

Updated

•

8 years ago

Target Milestone: mozilla48 → mozilla49

Kartikaya Gupta (email:kats@mozilla.staktrace.com)

Assignee

Comment 10

•

8 years ago

Comment on attachment 8745367 [details]
MozReview Request: Bug 1267246 - Remove bogus assertion. r?nical

Approval Request Comment
[Feature/regressing bug #]: bug 1264164 made this assertion fire much more frequently, but according to nical it was already getting hit sporadically. 
[User impact if declined]:no user - visible impact, but the assertion is bogus and causes unnecessary test failures
[Describe test coverage new/current, TreeHerder]: code is exercised in automated tests. 
[Risks and why]: low, just removing a debug assertion 
[String/UUID change made/needed]: none

Attachment #8745367 - Flags: approval-mozilla-aurora?

Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)

Comment 11

•

8 years ago

Comment on attachment 8745367 [details]
MozReview Request: Bug 1267246 - Remove bogus assertion. r?nical

Removes an unnecessary assert, Aurora48+

Attachment #8745367 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)

Comment 12

•

8 years ago

bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/bbb254427173

status-firefox48: affected → fixed

:gerard-majax

Comment 13

•

8 years ago

pushing this to pine since the crashes are hiding test runs in the context of ensuring coverage in bug 1266035: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d44ec31e38c2&filter-tier=1&filter-tier=2&filter-tier=3

https://hg.mozilla.org/projects/pine/rev/74f6380ed5a0

Whiteboard: [e10s-orangeblockers] → [e10s-orangeblockers] fixed-in-pine