1267269 - Make MIRType an enum class

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

The attached patch makes MIRType an enum class. 

We currently use a MIRType_ prefix for the enum values, so the difference is small (MIRType_Int32 -> MIRType::Int32). The main advantage here is better type safety.

There were ~2 places in IonTypes.h where I had to cast a MIRType to unsigned but other than that everything compiled fine after a global search-and-replace.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8744923 [details] [diff] [review]
Patch

Review of attachment 8744923 [details] [diff] [review]:
-----------------------------------------------------------------

Heroic! Thanks a lot for doing that.

Methodology for reviewing:
- apply the sed line, on the same parent revision
- commit
- diff the exported patches to see the differences

For what it's worth, the sed line I've used was:

for f in **/*.{h,cpp}; do mv $f $f.old; sed 's/MIRType_/MIRType::/g' $f.old > $f; rm -f $f.old; done

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b940a11bc559

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b940a11bc559