Closed
Bug 1267274
Opened 8 years ago
Closed 8 years ago
Firebug theme: Fix the Inspector toolbar button
Categories
(DevTools :: General, defect, P3)
DevTools
General
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
Firefox 49
People
(Reporter: Honza, Assigned: Honza)
References
Details
(Whiteboard: [btpp-backlog])
Attachments
(2 files, 1 obsolete file)
25.81 KB,
image/png
|
Details | |
798 bytes,
patch
|
Honza
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The inspector toolbar button (command-pick) should be moved a bit down in Firebug theme. See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1263889#c5 Honza
Assignee | ||
Updated•8 years ago
|
Blocks: improve-fb-theme
Assignee | ||
Comment 1•8 years ago
|
||
@Helen, patch that moves the button a bit down attached (this comes from your feedback) A screenshot (showing the diff) will follow. Honza
Assignee | ||
Comment 2•8 years ago
|
||
Updated•8 years ago
|
Attachment #8744929 -
Flags: review?(hholmes) → review+
Comment 4•8 years ago
|
||
Comment on attachment 8744929 [details] [diff] [review] bug1267274.patch Review of attachment 8744929 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/themes/firebug-theme.css @@ +245,5 @@ > min-width: 24px; > } > + > +/* Move the Inspector button a bit down (looks better) */ > +.theme-firebug #command-button-pick { Can you change this selector to .theme-firebug #command-button-pick > image ? This way we're not actually affecting the layout of the button, only the position of the image.
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Tim Nguyen :ntim from comment #4) > Can you change this selector to .theme-firebug #command-button-pick > image > ? This way we're not actually affecting the layout of the button, only the > position of the image. Done, patch updated. Honza
Attachment #8744929 -
Attachment is obsolete: true
Attachment #8745196 -
Flags: review+
Priority: -- → P3
Whiteboard: [btpp-backlog]
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cad94457610b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8745196 [details] [diff] [review] bug1267274.patch Approval Request Comment [Feature/regressing bug #]: bug 1244054 [User impact if declined]: Wrong position of an icon [Describe test coverage new/current, TreeHerder]: Nightly [Risks and why]: Low, CSS only [String/UUID change made/needed]: none Honza
Attachment #8745196 -
Flags: approval-mozilla-aurora?
status-firefox48:
--- → affected
Comment on attachment 8745196 [details] [diff] [review] bug1267274.patch Firebug theme related, CSS only, Aurora48+
Attachment #8745196 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 10•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/1a4d0996f35f
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•