Firebug theme: Fix the Inspector toolbar button

RESOLVED FIXED in Firefox 48

Status

()

Firefox
Developer Tools
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Honza, Assigned: Honza)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 49
Points:
---

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

(Whiteboard: [btpp-backlog])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

2 years ago
The inspector toolbar button (command-pick) should be moved a bit down in Firebug theme.

See also: 
https://bugzilla.mozilla.org/show_bug.cgi?id=1263889#c5

Honza
(Assignee)

Updated

2 years ago
Blocks: 1263889
(Assignee)

Comment 1

2 years ago
Created attachment 8744929 [details] [diff] [review]
bug1267274.patch

@Helen, patch that moves the button a bit down attached
(this comes from your feedback)

A screenshot (showing the diff) will follow.

Honza
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Attachment #8744929 - Flags: review?(hholmes)
(Assignee)

Comment 2

2 years ago
Created attachment 8744930 [details]
command-pick-screenshot.png
Attachment #8744929 - Flags: review?(hholmes) → review+
(Assignee)

Comment 3

2 years ago
Thanks Helen for the review.

Honza
Keywords: checkin-needed

Comment 4

2 years ago
Comment on attachment 8744929 [details] [diff] [review]
bug1267274.patch

Review of attachment 8744929 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/themes/firebug-theme.css
@@ +245,5 @@
>    min-width: 24px;
>  }
> +
> +/* Move the Inspector button a bit down (looks better) */
> +.theme-firebug #command-button-pick {

Can you change this selector to .theme-firebug #command-button-pick > image ? This way we're not actually affecting the layout of the button, only the position of the image.
(Assignee)

Comment 5

2 years ago
Created attachment 8745196 [details] [diff] [review]
bug1267274.patch

(In reply to Tim Nguyen :ntim from comment #4)
> Can you change this selector to .theme-firebug #command-button-pick > image
> ? This way we're not actually affecting the layout of the button, only the
> position of the image.
Done, patch updated.

Honza
Attachment #8744929 - Attachment is obsolete: true
Attachment #8745196 - Flags: review+

Comment 6

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/cad94457610b
Keywords: checkin-needed
Priority: -- → P3
Whiteboard: [btpp-backlog]

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cad94457610b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
(Assignee)

Comment 8

2 years ago
Comment on attachment 8745196 [details] [diff] [review]
bug1267274.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1244054
[User impact if declined]: Wrong position of an icon
[Describe test coverage new/current, TreeHerder]: Nightly
[Risks and why]: Low, CSS only
[String/UUID change made/needed]: none

Honza
Attachment #8745196 - Flags: approval-mozilla-aurora?

Updated

2 years ago
status-firefox48: --- → affected

Comment 9

2 years ago
Comment on attachment 8745196 [details] [diff] [review]
bug1267274.patch

Firebug theme related, CSS only, Aurora48+
Attachment #8745196 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 10

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/1a4d0996f35f
status-firefox48: affected → fixed
You need to log in before you can comment on or make changes to this bug.