Closed
Bug 1267357
Opened 8 years ago
Closed 8 years ago
NotificationPermissionRequest should cycle collect mCallback
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
(Whiteboard: [MemShrink])
Attachments
(1 file)
|
1.07 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1266912 +++ Another speculative fix for the leak in bug 1266912. NotificationPermissionRequest does not cycle collect its reference to mCallback and it probably should. This seems unlikely to be the leak I'm seeing, but lets fix it.
|
Assignee | |
Updated•8 years ago
|
Component: Notifications and Alerts → DOM
Product: Toolkit → Core
|
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8745015 -
Flags: review?(continuation)
|
||
Updated•8 years ago
|
Attachment #8745015 -
Flags: review?(continuation) → review+
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f94924ea05f2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
|
|
||
Updated•8 years ago
|
Target Milestone: mozilla48 → mozilla49
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•