Closed Bug 1267363 Opened 9 years ago Closed 9 years ago

Disable skia font hinting on os x if explicit about grayscale AA (fixes thin fonts in context menus)

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Version:
44 Branch
Platform:
Unspecified
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox47 --- unaffected
firefox48 --- fixed
firefox49 --- fixed
relnote-firefox --- 49+

People

(Reporter: mchang, Assigned: mchang)

References

Details

(Keywords: regression)

Attachments

(1 file)

grayscale.patch
1.88 KB, patch
mstange
: review+
ritu
: approval-mozilla-aurora+
Details | Diff | Splinter Review
No description provided.
Attached patch grayscale.patch — — Splinter Review
Attachment #8745031 - Flags: review?(mstange)
Attachment #8745031 - Flags: review?(mstange) → review+
This patch restores regular font weights to context menus, and it mitigates the flashing of thick-to-thin text that happens if layout toggles the transparency mode of a layer.
Blocks: 1260454
Keywords: regression
Summary: Disable skia font hinting on os x if explicit about grayscale AA → Disable skia font hinting on os x if explicit about grayscale AA (fixes thin fonts in context menus)
status-firefox47: --- → unaffected
status-firefox48: --- → affected
OS: Unspecified → Mac OS X
https://hg.mozilla.org/mozilla-central/rev/b6bfaeaa01a6
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Target Milestone: mozilla48 → mozilla49
Comment on attachment 8745031 [details] [diff] [review] grayscale.patch Approval Request Comment [Feature/regressing bug #]: bug 1260454 [User impact if declined]: Fonts can appear too thin due to grayscale AA. [Describe test coverage new/current, TreeHerder]: Manual testing [Risks and why]: Low, this fixes our behavior to what it was before bug 1260454. [String/UUID change made/needed]: None
Attachment #8745031 - Flags: approval-mozilla-aurora?
Comment on attachment 8745031 [details] [diff] [review] grayscale.patch Recent regression, Aurora48+
Attachment #8745031 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Release Note Request (optional, but appreciated) [Why is this notable]: [Suggested wording]: Resolved a problem on OS X where fonts could appear too thin due to anti-aliasing. [Links (documentation, blog post, etc)]:
relnote-firefox: --- → ?
49+ for the release note, added "Improved the appearance of OS X fonts"
relnote-firefox: ? → 49+
I don't think we ever shipped the broken version of this. Further, the release note "Improved the appearance of OS X fonts" feels devoid of any useful information. We should probably just remove this from the 49 release notes.
Flags: needinfo?(mozillamarcia.knous)
(In reply to Jeff Muizelaar [:jrmuizel] from comment #11) > I don't think we ever shipped the broken version of this. Further, the > release note "Improved the appearance of OS X fonts" feels devoid of any > useful information. > > We should probably just remove this from the 49 release notes. I removed this from the 49 release notes.
Flags: needinfo?(mozillamarcia.knous)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: