Closed Bug 1267369 Opened 4 years ago Closed 4 years ago

Stop generating typelib data for interfaces that aren't scriptable

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Splitting out work from bug 1267337 into its own bug because it is kinda a big change.
We are currently generating typelib data for all interfaces. Apparently
typelib data is only needed for scriptable interfaces. So let's stop
generating typelib data for interfaces that aren't scriptable.

The impact of this is that some typelibs are dropped from
interfaces.xpt, resulting in ~10kb smaller interfaces.xpt:

* nsIDOMCSSValue
* nsIDOMDOMImplementation
* nsIDOMDOMCursor
* nsIProfilerStartParams
* nsIStreamingProtocolMetaData
* nsIDOMCharacterData
* nsIPrintSession
* nsIDOMDocumentFragment
* nsIDOMProcessingInstruction
* nsIDOMElement
* nsIDOMText
* nsIDOMXULElement
* nsIDOMAttr
* nsIDOMGeoPositionError
* nsIXMLHttpRequestEventTarget
* nsIDOMCSSStyleDeclaration
* nsIDOMCSSStyleSheet
* nsIDOMDocument
* nsIDOMClientRect
* nsIDOMMozNamedAttrMap
* nsIDOMNode
* nsIThreadObserver
* nsIDOMDocumentType
* nsIXMLHttpRequestUpload
* nsISelection
* nsIDOMCDATASection
* nsIDOMDOMRequest
* nsIDOMComment
* nsIDOMEvent

Review commit: https://reviewboard.mozilla.org/r/48787/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48787/
Attachment #8745033 - Flags: review?(khuey)
Assignee: nobody → gps
Status: NEW → ASSIGNED
Comment on attachment 8745033 [details]
MozReview Request: Bug 1267369 - Only generate typelib data for scriptable interfaces; r?khuey

https://reviewboard.mozilla.org/r/48787/#review46133
Attachment #8745033 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/20f5f2164454
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.