Closed Bug 1267378 Opened 4 years ago Closed 4 years ago

fix eslint errors in css-color.js

Categories

(DevTools :: Inspector, enhancement, P1)

enhancement

Tracking

(firefox49 fixed)

RESOLVED FIXED
Firefox 49
Iteration:
49.1 - May 9
Tracking Status
firefox49 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file)

I might touch css-color.js and thought I'd fix the eslint warnings first.
Blocks: 1266842
Comment on attachment 8745048 [details]
MozReview Request: Bug 1267378 - fix eslint errors in css-color.js; r?miker

https://reviewboard.mozilla.org/r/48791/#review45823
Attachment #8745048 - Flags: review?(mratcliffe) → review+
Severity: normal → enhancement
Whiteboard: [devtools-html]
Keywords: checkin-needed
seems it does not work as expected -> https://treeherder.mozilla.org/logviewer.html#?job_id=9038368&repo=fx-team

tier-2 failure so no backout
Flags: needinfo?(ttromey)
An eslint rule change was landed that forces a space between an anonymous function and it's brackets and this patch was written before it landed.
Iteration: --- → 49.1 - May 9
Flags: qe-verify-
Priority: -- → P1
Two patches crossing in the night.

Meanwhile this seems to have been fixed already:

commit 7609e9309afff922c6a51d030223f4408385fbfd
Author: Matthew Noorenberghe <mozilla@noorenberghe.ca>
Date:   Thu Apr 28 01:19:08 2016 -0700

    Bug 1267378 - Follow-up to fix devtools space-before-function-paren errors
    
    MozReview-Commit-ID: DCCsgYbGxcr


... but this seems strange to me somehow -- no "r=" and also no discussion in this bug.
In any case the patch is correct and the problem fixed.
Flags: needinfo?(ttromey)
https://hg.mozilla.org/mozilla-central/rev/da735eadeed7
https://hg.mozilla.org/mozilla-central/rev/d2a63cc368c9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.