Closed
Bug 1267378
Opened 9 years ago
Closed 9 years ago
fix eslint errors in css-color.js
Categories
(DevTools :: Inspector, enhancement, P1)
DevTools
Inspector
Tracking
(firefox49 fixed)
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
(Whiteboard: [devtools-html])
Attachments
(1 file)
I might touch css-color.js and thought I'd fix the eslint warnings first.
Assignee | ||
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/48791/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48791/
Attachment #8745048 -
Flags: review?(mratcliffe)
Assignee | ||
Updated•9 years ago
|
Blocks: devtools-eslint
Comment on attachment 8745048 [details]
MozReview Request: Bug 1267378 - fix eslint errors in css-color.js; r?miker
https://reviewboard.mozilla.org/r/48791/#review45823
Attachment #8745048 -
Flags: review?(mratcliffe) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Updated•9 years ago
|
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 5•9 years ago
|
||
seems it does not work as expected -> https://treeherder.mozilla.org/logviewer.html#?job_id=9038368&repo=fx-team
tier-2 failure so no backout
Flags: needinfo?(ttromey)
An eslint rule change was landed that forces a space between an anonymous function and it's brackets and this patch was written before it landed.
Updated•9 years ago
|
Iteration: --- → 49.1 - May 9
Flags: qe-verify-
Priority: -- → P1
Assignee | ||
Comment 8•9 years ago
|
||
Two patches crossing in the night.
Meanwhile this seems to have been fixed already:
commit 7609e9309afff922c6a51d030223f4408385fbfd
Author: Matthew Noorenberghe <mozilla@noorenberghe.ca>
Date: Thu Apr 28 01:19:08 2016 -0700
Bug 1267378 - Follow-up to fix devtools space-before-function-paren errors
MozReview-Commit-ID: DCCsgYbGxcr
... but this seems strange to me somehow -- no "r=" and also no discussion in this bug.
In any case the patch is correct and the problem fixed.
Flags: needinfo?(ttromey)
Comment 9•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/da735eadeed7
https://hg.mozilla.org/mozilla-central/rev/d2a63cc368c9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•