Closed Bug 1267378 Opened 4 years ago Closed 4 years ago
fix eslint errors in css-color
58 bytes, text/x-review-board-request
I might touch css-color.js and thought I'd fix the eslint warnings first.
Review commit: https://reviewboard.mozilla.org/r/48791/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48791/
Attachment #8745048 - Flags: review?(mratcliffe)
Comment on attachment 8745048 [details] MozReview Request: Bug 1267378 - fix eslint errors in css-color.js; r?miker https://reviewboard.mozilla.org/r/48791/#review45823
Attachment #8745048 - Flags: review?(mratcliffe) → review+
Severity: normal → enhancement
seems it does not work as expected -> https://treeherder.mozilla.org/logviewer.html#?job_id=9038368&repo=fx-team tier-2 failure so no backout
An eslint rule change was landed that forces a space between an anonymous function and it's brackets and this patch was written before it landed.
Iteration: --- → 49.1 - May 9
Priority: -- → P1
Two patches crossing in the night. Meanwhile this seems to have been fixed already: commit 7609e9309afff922c6a51d030223f4408385fbfd Author: Matthew Noorenberghe <email@example.com> Date: Thu Apr 28 01:19:08 2016 -0700 Bug 1267378 - Follow-up to fix devtools space-before-function-paren errors MozReview-Commit-ID: DCCsgYbGxcr ... but this seems strange to me somehow -- no "r=" and also no discussion in this bug. In any case the patch is correct and the problem fixed.
You need to log in before you can comment on or make changes to this bug.