1267412 - Use MutableHandle for output vectors rather than AutoRooter*

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: 4.1_dont_pass_AutoValueVector_by_reference-v0.diff

There are a ton of them. These are the low-hanging fruit. More to come.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8745081 [details] [diff] [review]
4.1_dont_pass_AutoValueVector_by_reference-v0.diff

Review of attachment 8745081 [details] [diff] [review]:
-----------------------------------------------------------------

Quite a mouthful, but easier to understand what's going on.

Comment 2

[Terrence Cole [:terrence]]

Attachment: 4.2_more_AutoValueVector_outputs-v0.diff

This is the last of the pointer-to-Vector outputs. But it turns out there are a whole page of ones using a ref for the output vector that I missed. Those are up next.

Comment 3

[Terrence Cole [:terrence]]

Attachment: 4.3_AutoValueVector_ref_outputs-v0.diff

Only one usage left, but it's in Gecko. I'd like to move GCContainer to the JS namespace before I fix that one.

Comment 4

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3081c3bd90f

Comment 5

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e97e2282142b206ef97d13045eac502b58201ed
Bug 1267412 - Use MutableHandleValue instead of pointer-to-AutoValueVector; r=sfink

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9e97e2282142