Closed Bug 1267412 Opened 4 years ago Closed 4 years ago

Use MutableHandle for output vectors rather than AutoRooter*

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 --- affected
firefox49 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

There are a ton of them. These are the low-hanging fruit. More to come.
Attachment #8745081 - Flags: review?(sphink)
Comment on attachment 8745081 [details] [diff] [review]
4.1_dont_pass_AutoValueVector_by_reference-v0.diff

Review of attachment 8745081 [details] [diff] [review]:
-----------------------------------------------------------------

Quite a mouthful, but easier to understand what's going on.
Attachment #8745081 - Flags: review?(sphink) → review+
This is the last of the pointer-to-Vector outputs. But it turns out there are a whole page of ones using a ref for the output vector that I missed. Those are up next.
Attachment #8745093 - Flags: review?(sphink)
Attachment #8745093 - Flags: review?(sphink) → review+
Only one usage left, but it's in Gecko. I'd like to move GCContainer to the JS namespace before I fix that one.
Attachment #8745109 - Flags: review?(sphink)
Attachment #8745109 - Flags: review?(sphink) → review+
Blocks: GC.stability
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e97e2282142b206ef97d13045eac502b58201ed
Bug 1267412 - Use MutableHandleValue instead of pointer-to-AutoValueVector; r=sfink
https://hg.mozilla.org/mozilla-central/rev/9e97e2282142
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Depends on: 1270278
Depends on: 1272908
You need to log in before you can comment on or make changes to this bug.