Closed
Bug 1267434
Opened 8 years ago
Closed 8 years ago
Unnecessary whitespace displayed after aboutPrivateBrowsing.info.saved.emphasize in about:privatebrowing
Categories
(Firefox :: Private Browsing, defect, P1)
Firefox
Private Browsing
Tracking
()
People
(Reporter: flod, Assigned: rickychien)
References
Details
(Whiteboard: [fxprivacy])
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
Gijs
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
An unexpected whitespace is currently displayed after "will save" http://hg.mozilla.org/mozilla-central/rev/463fc6d36ff5#l3.77 Proof is that the next string "your:" doesn't start with a space. http://hg.mozilla.org/mozilla-central/rev/463fc6d36ff5#l6.26 Layout should not add spaces in the middle of a sentence, that's something that strings should do.
Comment 1•8 years ago
|
||
Ricky, could you submit a quick patch for this? Thanks!
Assignee: nobody → rchien
Flags: needinfo?(rchien)
Updated•8 years ago
|
Priority: -- → P3
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/49135/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49135/
Attachment #8745866 -
Flags: review?(gijskruitbosch+bugs)
Reporter | ||
Comment 4•8 years ago
|
||
https://reviewboard.mozilla.org/r/49135/#review45951 ::: browser/locales/en-US/chrome/browser/aboutPrivateBrowsing.dtd:20 (Diff revision 1) > <!ENTITY aboutPrivateBrowsing.info.searches "searches"> > <!ENTITY aboutPrivateBrowsing.info.cookies "cookies"> > <!ENTITY aboutPrivateBrowsing.info.temporaryFiles "temporary files"> > <!ENTITY aboutPrivateBrowsing.info.saved.before "Firefox "> > <!ENTITY aboutPrivateBrowsing.info.saved.emphasize "will save"> > -<!ENTITY aboutPrivateBrowsing.info.saved.after "your:"> > +<!ENTITY aboutPrivateBrowsing.info.saved.after " your:"> And sadly at this point you'll need a new key.
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8745866 [details] MozReview Request: Bug 1267434 - Unnecessary whitespace displayed in about:privatebrowing; r?Gijs Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49135/diff/1-2/
Assignee | ||
Comment 6•8 years ago
|
||
Oops! thank you for quickly reply, aboutPrivateBrowsing.dtd was updated.
Updated•8 years ago
|
Attachment #8745866 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 7•8 years ago
|
||
Comment on attachment 8745866 [details] MozReview Request: Bug 1267434 - Unnecessary whitespace displayed in about:privatebrowing; r?Gijs https://reviewboard.mozilla.org/r/49135/#review46051 r=me Flod, what do you want to do about uplifts / 48 ? The original patch made 48, and this obviously won't anymore unless we uplift.
Comment 8•8 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #7) > Flod, what do you want to do about uplifts / 48 ? The original patch made > 48, and this obviously won't anymore unless we uplift.
Flags: needinfo?(francesco.lodolo)
Reporter | ||
Comment 9•8 years ago
|
||
I'm a bit torn, but I think we should try to land this as soon as possible in aurora. For Italian I had to do a trick like moving the ":" to the string before, French now has two spaces. We might want to add a note to this bug in the report we send out to localizers (@jeff: there should be a string freeze break to fix the localizability of the new about:privatebrowsing window)
Flags: needinfo?(francesco.lodolo)
Comment 11•8 years ago
|
||
Comment on attachment 8745866 [details] MozReview Request: Bug 1267434 - Unnecessary whitespace displayed in about:privatebrowing; r?Gijs (In reply to Francesco Lodolo [:flod] from comment #9) > I'm a bit torn, but I think we should try to land this as soon as possible > in aurora. Approval Request Comment [Feature/regressing bug #]: bug 1259340 [User impact if declined]: l10n issues for non-English [Describe test coverage new/current, TreeHerder]: nope [Risks and why]: very low, tiny string + HTML change [String/UUID change made/needed]: yes, there is a string change, but see above - we branched 2 days ago, so IMO we should just get it in real quick. :-\
Flags: needinfo?(sledru)
Flags: needinfo?(lhenry)
Attachment #8745866 -
Flags: approval-mozilla-aurora?
Comment 12•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/099e2bf3ce03
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Updated•8 years ago
|
Iteration: --- → 49.1 - May 9
Flags: qe-verify?
Priority: P3 → P1
Comment 13•8 years ago
|
||
Comment on attachment 8745866 [details] MozReview Request: Bug 1267434 - Unnecessary whitespace displayed in about:privatebrowing; r?Gijs OK to uplift to aurora though there is a small string change, since flod approves
Flags: needinfo?(lhenry)
Attachment #8745866 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•8 years ago
|
Flags: needinfo?(sledru)
You need to log in
before you can comment on or make changes to this bug.
Description
•