1267434 - Unnecessary whitespace displayed after aboutPrivateBrowsing.info.saved.emphasize in about:privatebrowing

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect, P1)

Description

[Francesco Lodolo [:flod]]

An unexpected whitespace is currently displayed after "will save"
http://hg.mozilla.org/mozilla-central/rev/463fc6d36ff5#l3.77

Proof is that the next string "your:" doesn't start with a space.
http://hg.mozilla.org/mozilla-central/rev/463fc6d36ff5#l6.26

Layout should not add spaces in the middle of a sentence, that's something that strings should do.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Ricky, could you submit a quick patch for this? Thanks!

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Sure.

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Attachment: MozReview Request: Bug 1267434 - Unnecessary whitespace displayed in about:privatebrowing; r?Gijs

Review commit: https://reviewboard.mozilla.org/r/49135/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49135/

Comment 4

[Francesco Lodolo [:flod]]

https://reviewboard.mozilla.org/r/49135/#review45951

::: browser/locales/en-US/chrome/browser/aboutPrivateBrowsing.dtd:20
(Diff revision 1)
>  <!ENTITY aboutPrivateBrowsing.info.searches              "searches">
>  <!ENTITY aboutPrivateBrowsing.info.cookies               "cookies">
>  <!ENTITY aboutPrivateBrowsing.info.temporaryFiles        "temporary files">
>  <!ENTITY aboutPrivateBrowsing.info.saved.before          "Firefox ">
>  <!ENTITY aboutPrivateBrowsing.info.saved.emphasize       "will save">
> -<!ENTITY aboutPrivateBrowsing.info.saved.after           "your:">
> +<!ENTITY aboutPrivateBrowsing.info.saved.after           " your:">

And sadly at this point you'll need a new key.

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8745866 [details]
MozReview Request: Bug 1267434 - Unnecessary whitespace displayed in about:privatebrowing; r?Gijs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49135/diff/1-2/

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Oops! thank you for quickly reply, aboutPrivateBrowsing.dtd was updated.

Comment 7

[:Gijs (he/him)]

Comment on attachment 8745866 [details]
MozReview Request: Bug 1267434 - Unnecessary whitespace displayed in about:privatebrowing; r?Gijs

https://reviewboard.mozilla.org/r/49135/#review46051

r=me

Flod, what do you want to do about uplifts / 48 ? The original patch made 48, and this obviously won't anymore unless we uplift.

Comment 8

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #7)
> Flod, what do you want to do about uplifts / 48 ? The original patch made
> 48, and this obviously won't anymore unless we uplift.

Comment 9

[Francesco Lodolo [:flod]]

I'm a bit torn, but I think we should try to land this as soon as possible in aurora.

For Italian I had to do a trick like moving the ":" to the string before, French now has two spaces.

We might want to add a note to this bug in the report we send out to localizers (@jeff: there should be a string freeze break to fix the localizability of the new about:privatebrowsing window)

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/099e2bf3ce03

Comment 11

[:Gijs (he/him)]

Comment on attachment 8745866 [details]
MozReview Request: Bug 1267434 - Unnecessary whitespace displayed in about:privatebrowing; r?Gijs

(In reply to Francesco Lodolo [:flod] from comment #9)
> I'm a bit torn, but I think we should try to land this as soon as possible
> in aurora.


Approval Request Comment
[Feature/regressing bug #]: bug 1259340
[User impact if declined]: l10n issues for non-English
[Describe test coverage new/current, TreeHerder]: nope
[Risks and why]: very low, tiny string + HTML change
[String/UUID change made/needed]: yes, there is a string change, but see above - we branched 2 days ago, so IMO we should just get it in real quick. :-\

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/099e2bf3ce03

Comment 13

[Liz Henry (:lizzard)]

Comment on attachment 8745866 [details]
MozReview Request: Bug 1267434 - Unnecessary whitespace displayed in about:privatebrowing; r?Gijs

OK to uplift to aurora though there is a small string change, since flod approves

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7c7a6fe3b94b