Closed
Bug 1267437
Opened 8 years ago
Closed 8 years ago
Visual Studio backend should generate projects for all binaries
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox49 fixed)
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: molly, Unassigned)
Details
Attachments
(1 file)
Currently, the mozbuild Visual Studio backend outputs a project for each library in the build, plus a few hardcoded projects for running/debugging specific programs. This means that source files which are associated directly with a program and not through a library are entirely excluded, and that only the hardcoded binaries are available for debugging (aside from opening the binary separately as its own solution, but that's not as convenient). Instead, every program should get its own project, just as every library does, which contains the source and include files used in that program and which allows launching it for debugging. Note: patch incoming.
Reporter | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/48849/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48849/
Reporter | ||
Updated•8 years ago
|
Attachment #8745102 -
Flags: review?(gps)
Updated•8 years ago
|
Attachment #8745102 -
Flags: review?(gps) → review+
Comment 2•8 years ago
|
||
Comment on attachment 8745102 [details] MozReview Request: Bug 1267437 - Generate projects in the Visual Studio backend for every binary generated by the build https://reviewboard.mozilla.org/r/48849/#review45719 I applied this locally and this looks great! Thanks a bunch! If you are looking for another improvement to Visual Studio project generation, bug 1260299 should be relatively low-hanging fruit :)
Reporter | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5f6c9ac2919a
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•8 years ago
|
Target Milestone: mozilla48 → mozilla49
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•