Intermittent test_session_form_data.html | Test timed out.

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: KWierso, Assigned: JanH)

Tracking

({intermittent-failure})

Trunk
Firefox 49
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Comment 1

3 years ago
For some reason or other, it seems the "load" event after opening/navigating within/restoring a tab takes ages to arrive on the emulator, which accounts for a clear majority of the time spent in this test.
See Also: → bug 1268177
(Assignee)

Updated

3 years ago
See Also: bug 1268177
(Assignee)

Comment 2

3 years ago
Created attachment 8747461 [details]
MozReview Request: Bug 1267481 - Increase test_session_form_data.html timeout. r=gbrown

Opening/navigating within/restoring a tab seems to be relatively slow on the emulator and as we want to test whether form data is preserved by the session store after closing and restoring a tab, quite a bit of time is accumulated that way.

Review commit: https://reviewboard.mozilla.org/r/49905/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49905/
Attachment #8747461 - Flags: review?(margaret.leibovic)
(Assignee)

Updated

3 years ago
Assignee: nobody → jh+bugzilla
Comment on attachment 8747461 [details]
MozReview Request: Bug 1267481 - Increase test_session_form_data.html timeout. r=gbrown

Redirecting this review to gbrown, since he has more experience with these timeouts.
Attachment #8747461 - Flags: review?(margaret.leibovic) → review?(gbrown)
Comment on attachment 8747461 [details]
MozReview Request: Bug 1267481 - Increase test_session_form_data.html timeout. r=gbrown

https://reviewboard.mozilla.org/r/49905/#review47557

This seems reasonable.

An alternative would be to split the test into 2 or more smaller tests.
Attachment #8747461 - Flags: review?(gbrown) → review+
(Assignee)

Comment 5

3 years ago
Comment on attachment 8747461 [details]
MozReview Request: Bug 1267481 - Increase test_session_form_data.html timeout. r=gbrown

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49905/diff/1-2/
Attachment #8747461 - Attachment description: MozReview Request: Bug 1267481 - Increase test_session_form_data.html timeout. r=margaret → MozReview Request: Bug 1267481 - Increase test_session_form_data.html timeout. r=gbrown

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d7f05bf878f4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49

Comment 9

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/1dd7b155900e
status-firefox48: affected → fixed
You need to log in before you can comment on or make changes to this bug.