Closed Bug 1267481 Opened 4 years ago Closed 4 years ago

Intermittent test_session_form_data.html | Test timed out.

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: KWierso, Assigned: JanH)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

For some reason or other, it seems the "load" event after opening/navigating within/restoring a tab takes ages to arrive on the emulator, which accounts for a clear majority of the time spent in this test.
See Also: → 1268177
See Also: 1268177
Opening/navigating within/restoring a tab seems to be relatively slow on the emulator and as we want to test whether form data is preserved by the session store after closing and restoring a tab, quite a bit of time is accumulated that way.

Review commit: https://reviewboard.mozilla.org/r/49905/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49905/
Attachment #8747461 - Flags: review?(margaret.leibovic)
Assignee: nobody → jh+bugzilla
Comment on attachment 8747461 [details]
MozReview Request: Bug 1267481 - Increase test_session_form_data.html timeout. r=gbrown

Redirecting this review to gbrown, since he has more experience with these timeouts.
Attachment #8747461 - Flags: review?(margaret.leibovic) → review?(gbrown)
Comment on attachment 8747461 [details]
MozReview Request: Bug 1267481 - Increase test_session_form_data.html timeout. r=gbrown

https://reviewboard.mozilla.org/r/49905/#review47557

This seems reasonable.

An alternative would be to split the test into 2 or more smaller tests.
Attachment #8747461 - Flags: review?(gbrown) → review+
Comment on attachment 8747461 [details]
MozReview Request: Bug 1267481 - Increase test_session_form_data.html timeout. r=gbrown

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49905/diff/1-2/
Attachment #8747461 - Attachment description: MozReview Request: Bug 1267481 - Increase test_session_form_data.html timeout. r=margaret → MozReview Request: Bug 1267481 - Increase test_session_form_data.html timeout. r=gbrown
https://hg.mozilla.org/mozilla-central/rev/d7f05bf878f4
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.