1267544 - disable the Fish trophy?!

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[(no longer active)]

MozReview is suggesting that Alastor Wu has got a fish trophy!  <https://reviewboard.mozilla.org/r/32423/diff/7#6>  I'm not sure what this means.

Comment 1

[:glob ✱]

it's upstream silliness: https://github.com/reviewboard/reviewboard/blob/master/reviewboard/accounts/trophies.py#L71

Comment 2

[(no longer active)]

"Give a man a fish, he'll waste hours trying to figure out why.".

I'm speechless!  Mission accomplished, I guess?

Comment 3

[Andrew McCreight [:mccr8]]

Can we remove this or have a tooltip explanation somewhere so I don't waste a bunch of time trying to read reviewboard source code to figure it out? (It looks like it is for reviews where the id is a palindrome.)

Comment 4

[:glob ✱]

Attachment: mozreview: hide trophies (bug 1267544)

The fish trophy is, honestly, a waste of time, and we'll never hit milestone
trophies.

Unregistering the trophie classes from an extension doesn't appear to work, and
if we modify the trophy code we'd have to update extra_data on all review
requests to force a recalculation.  Easiest option is to hide trophies with
css.

Review commit: https://reviewboard.mozilla.org/r/63008/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63008/

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8769032 [details]
mozreview: hide trophies (bug 1267544)

https://reviewboard.mozilla.org/r/63008/#review60100

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/217525085c1d
mozreview: hide trophies r=gps