Closed Bug 1267553 Opened 5 years ago Closed 4 years ago

[Transition] Show top sites screen in the search app

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: apastor, Assigned: apastor)

References

Details

(Whiteboard: [Transition])

Attachments

(1 file)

At the moment, we don't see any top site when opening the Search app. We need to make the top-sites section work again.
Assignee: nobody → apastor
Comment on attachment 8745961 [details] [review]
[gaia] albertopq:1267553-top-sites > mozilla-b2g:kanikani

Moved all the search IDB logic to places.js in order to use the same structure. Removed SyncDatastore logic.
Attachment #8745961 - Flags: review?(bfrancis)
Comment on attachment 8745961 [details] [review]
[gaia] albertopq:1267553-top-sites > mozilla-b2g:kanikani

Thanks Alberto. I left some comments on GitHub.

What's the reason that we still need separate places.js and places_idb.js. Can we not combine all the logic in one place?
Attachment #8745961 - Flags: review?(bfrancis)
To be honest, no other reason that not breaking code that I don't know well, making as little changes as possible (in the same way is happening in the Homescreen). Thanks for the comments, I'll take a look!
See Also: → 1269285
Comment on attachment 8745961 [details] [review]
[gaia] albertopq:1267553-top-sites > mozilla-b2g:kanikani

Amended comments and filed bug 1269285. Also, re-enabled screenshots in top sites. Thanks!
Attachment #8745961 - Flags: review?(bfrancis)
Comment on attachment 8745961 [details] [review]
[gaia] albertopq:1267553-top-sites > mozilla-b2g:kanikani

Thanks Alberto!
Attachment #8745961 - Flags: review?(bfrancis) → review+
kanikani: https://github.com/mozilla-b2g/gaia/commit/1c083b54c963bcab39980bb65adfb54e6f05d0bc
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Blocks: 1270022
You need to log in before you can comment on or make changes to this bug.