1267593 - Today's Widget to open tabs buttons are not displayed after changing device orientation

Status: RESOLVED WORKSFORME

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Build: master 3be0655

Steps to reproduce:
1. Launch Firefox
2. Swipe down to open Today Widget menu
3. Scroll to the bottom of the menu
4. Swipe up to close Today Widget menu
5. Change device orientation to landscape
6. Swipe down to open Today Widget menu
7. Scroll to the top of the menu

Actual results:
- The Today's Widget to open tabs buttons are not displayed

Expected results:
- The Widget buttons should be displayed

Comment 1

[Simon Basca [:SimonB]]

Attachment: Please see the attached screenshot for more information.

Comment 2

[Emily Toop (:fluffyemily)]

Can you still reproduce this on a device with the latest master?

Comment 3

[Simon Basca [:SimonB]]

Tested with latest master 1649ceb8.

The issue is reproducible following the STR from the description.

Comment 4

[Simon Basca [:SimonB]]

Attachment: Tested on latest master 1649ceb8

Comment 5

[Emily Toop (:fluffyemily)]

After investigation, sometimes the Today widget is not called when it is displayed. I have not managed to 
figure out why that is. 

Setting breakpoints in init, viewDidLoad and viewDidLayoutSubview confirms that when the widget appears, these functions are called as expected, however when it is not displayed, those breakpoints are never hit.

Comment 6

[Stephan Leroux [:sleroux]]

Haven't been seeing this lately. Will reopen if we see it again.

Comment 7

[Catalin Suciu [:csuciu]]

Attachment: Screen Shot 2016-10-17 at 16.22.39.png

I'm able to reproduce this issue on latest master (6a18631e369) running on iPhone 6 Plus (9.3.5)

STR:
1. While in landscape, swipe down from the top of the screen to open Today view.
2. Scroll Fennec(master) widget out of view
3. Dismiss Today view
4. Switch to portrait and open Today view
5. Scroll Fennec widget into view

Result: The widget buttons are missing

I'm can't reproduce this issue on other devices

Comment 8

[Catalin Suciu [:csuciu]]

*  I can't reproduce this issue on other devices

Comment 9

[Farhan Patel [:farhan]]

I think I fixed this in another patch. I can't reproduce this anymore.