126764 - bookmarks context menus are empty

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

accidentally checked in some debugging code with bookmarks changes that are 
causing bookmarks context menus not to show.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

here's the patch. bugzilla's shitty login cookie is failing me:

Index: bookmarks.xul
===================================================================
RCS file: /cvsroot/mozilla/xpfe/components/bookmarks/resources/bookmarks.xul,v
retrieving revision 1.149
diff -w -b -u -r1.149 bookmarks.xul
--- bookmarks.xul	20 Feb 2002 04:16:30 -0000	1.149
+++ bookmarks.xul	20 Feb 2002 21:05:31 -0000
@@ -60,6 +60,10 @@
   <!-- XXX - This should SO become an XBL widget -->
   <script type="application/x-javascript" 
src="chrome://global/content/globalOverlay.js"></script>
   
+  <!-- Shared Bookmarks Utility Library -->
+  <script type="application/x-javascript" 
src="chrome://communicator/content/bookmarks/bookmarksOverlay.js"/>
+  <!-- Tree-based Bookmarks UI Utility Library -->
+  <script type="application/x-javascript" 
src="chrome://communicator/content/bookmarks/bookmarksTree.js"/>
   <!-- Bookmarks Window -->
   <script type="application/x-javascript" 
src="chrome://communicator/content/bookmarks/bookmarks.js"/>
 
@@ -147,7 +151,6 @@
                     label="&command.properties.label;" 
                     accesskey="&command.properties.accesskey;" />
           <menuitem id="menu_sendPage" hidden="true"/>
-          <menuitem label="Import IE Favorites" oncommand="importIEFavorites
();"/>
         </menupopup>
       </menu>
       <menu id="menu_Edit">

Comment 2

[Blake Ross]

sr=me

Comment 3

[John Keiser (jkeiser)]

r=jkeiser

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

a=roc+moz for 0.9.9

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed. 

Comment 6

[R.K.Aa.]

on various cvs builds on linux today, context menus in bookmarks sidebar was
never gone.

I noticed this bug got filed, so i pulled and rebuild - but context menus were
still there - in sidebar.

In a build with this patch, however, bookmarks in sidebar vanish when i
right-click on them. Also when i click a folder. They reappear when i click a
link on a webpage or open a new tab etc.