We now have 2.5* instances of almost the same code to handle embedding the FxA iframe. We should consolidate these instances into one reusable library to keep things DRY. https://github.com/mozilla/bedrock/blob/master/media/js/firefox/firstrun/firstrun.js https://github.com/mozilla/bedrock/blob/master/media/js/firefox/accounts.js * One instance is currently in code review.
:garethc - Can you review demo3 to ensure GA is still working as expected/well enough to merge/push this change? You'll need to create a new profile to test FxA on a demo , then will be able to hit the FxA-related pages on demo3  to fire off GA events. Thanks!  http://bedrock.readthedocs.io/en/latest/firefox-accounts.html#demo-server-testing  https://www-demo3.allizom.org/en-US/firefox/47.0/firstrun/  https://www-demo3.allizom.org/en-US/firefox/47.0/firstrun/?v=6  https://www-demo3.allizom.org/en-US/firefox/accounts/
Hi Jon, I was able to validate the first url :https://www-demo3.allizom.org/en-US/firefox/47.0/firstrun/ (http://cl.ly/0R0w0146231t) But on URLS 3&4 the system didn't look like it was able to actually sign up a user. Consequently I saw no tagging. http://cl.ly/0Y2d2f0a0Q3u Let me know what else I can do. Thanks, PG
Hey Peter - Hm, sometimes the FxA staging server can be unreliable. I was just able to successfully sign up at all 3 URLs. Can you give it another try? Or, can you see if tagging just came through for the /firstrun/?v=6 and /accounts URLs? I suggest trying different email addresses each time (I use mailinator.com for throwaway addresses). Also, make sure to sign out of Sync and clear the FxA cache (by visiting https://accounts.stage.mozaws.net/clear) between signups. Let me know if you continue to be unable to sign up.
Hi Jon, I was using a mailinator address. That said, it looks like there are events coming through on all three pages. The only thing is that the /accounts/ page does not have any data for 'Firefox Account' coming through in the EventLabel. http://cl.ly/2h2w2G1k190r Thanks, PG
Hmm, I'm actually not sure where that 'Firefox Account' Event Label is coming from. There's nothing specific in our FxA iframe JS sending that label value. Could it be coming from the FxA side? Or possibly a rule present in GTM? Can we tell when that label is being sent? Is it on page load, or after interacting with the page in some way?
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/e4027d01e68da7ba4479b428af10344525374cf4 [fix bug 1267658] Create shared FxA iframe JS lib. https://github.com/mozilla/bedrock/commit/bb9a79f03070f20b9c9827bc3434195b555ba77a Merge pull request #4136 from jpetto/bug-1267658-create-fxa-iframe-js-lib [fix bug 1267658] Create shared FxA iframe JS lib.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.