Closed Bug 1267691 Opened 8 years ago Closed 8 years ago

Upgrade can't-shutdown-thread-from-itself warning to MOZ_ASSERT()

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: jesup, Assigned: jesup)

Details

Attachments

(1 file)

Assert on failed attempts to shutdown a thread from itself r?froyd
834 bytes, patch
froydnj
: review+
Details | Diff | Splinter Review 
The warning gets totally lost, and we should know when a thread fails to shut down.  Separately, there has been discussion of making this dispatchtomainthread the shutdown if someone tries this, or make it an optional feature you can ask for for a thread.  That's a separate discussion however.
Attachment #8745395 - Flags: review?(nfroyd)
Attachment #8745395 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/776206651faa
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: