1267718 - Add a nsPIDOMWindow::GetScriptableParentOrNull method

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonathan Watt [:jwatt]]

In bug 1162772 I've found myself twice writing;

  nsPIDOMWindowOuter* parentOuterWin = GetScriptableParent();
  MOZ_ASSERT(parentOuterWin, "How can we get here? No docShell somehow?");
  if (nsGlobalWindow::Cast(parentOuterWin) != this) {

which could be more simply written as:

  if (GetScriptableParentOrNull()) {

if that method existed.  There are a few other places in the code that might benefit from this function too, but to a lesser extent.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8745436 [details] [diff] [review]
patch

nsPIDOMWindow.h needs documentation for the new method.  r=me with that.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7beb35b55c7

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d7beb35b55c7