Closed Bug 1267860 Opened 6 years ago Closed 6 years ago

Push notification does not show payload string in Android devices

Categories

(Toolkit :: Notifications and Alerts, defect)

48 Branch
All
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla49
Tracking Status
firefox47 --- unaffected
firefox48 + fixed
firefox49 --- fixed
fennec 48+ ---

People

(Reporter: Abe_LV, Assigned: jchen)

References

Details

(Keywords: regression)

Attachments

(1 file)

The push notification does not display the payload string in Android devices. 
But it shows in desktop.

Steps to Reproduce:
1. Using Android device with latest nightly, go to :https://serviceworke.rs/push-payload_demo.html
2. Change Notification payload to contain string, like "testtext"
3. Press the [Request sending a notification!] button
4. Verify the notification displays the payload string, "testtext"

Actual Result:
Notification does not show payload.

Expected Result:
Notification should show the payload string.
Flags: needinfo?(edwong)
:margaret - do we have anyone who can investigate this?
Flags: needinfo?(edwong) → needinfo?(margaret.leibovic)
I believe jchen is working on this.
Flags: needinfo?(margaret.leibovic) → needinfo?(nchen)
This is specific to encryption and sending encrypted payload to through the web push server.  Nalexander was working on this before.  I could be wrong, but jchen was working mostly on headless launch and processing of gcm event.
Flags: needinfo?(margaret.leibovic)
I think I know what's going on.
Assignee: nobody → nchen
Flags: needinfo?(nchen)
Awesome, thanks jchen. Let me know if you need someone from my team to help out.
Flags: needinfo?(margaret.leibovic)
Blocks: 1257821
Status: NEW → ASSIGNED
Keywords: regression
Include the content encoding "con" parameter in the message that is
passed from GCM to Gecko, so that the message body can be correctly
decrypted.
Attachment #8746106 - Flags: review?(kcambridge)
tracking-fennec: --- → ?
Comment on attachment 8746106 [details] [diff] [review]
Include "con" parameter in GCM message (v1)

Review of attachment 8746106 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks!
Attachment #8746106 - Flags: review?(kcambridge) → review+
https://hg.mozilla.org/mozilla-central/rev/ce3035337782
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Fixed on Android Devices reference: https://docs.google.com/spreadsheets/d/1tXCl9QN7alRER292VsrXK_stxFB-4oVisr0TvkNpxkc/edit#gid=1832365738
Build ID 2016050303042
Status: RESOLVED → VERIFIED
jchen, should this be uplifted to Aurora?
Flags: needinfo?(nchen)
Yep, thanks!
Flags: needinfo?(nchen)
Comment on attachment 8746106 [details] [diff] [review]
Include "con" parameter in GCM message (v1)

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Push notification cannot show messages
[Describe test coverage new/current, TreeHerder]: Locally, m-c
[Risks and why]: No risk; one line patch to fix the bug
[String/UUID change made/needed]: None
Attachment #8746106 - Flags: approval-mozilla-aurora?
tracking-fennec: ? → 48+
[Tracking Requested - why for this release]: Push notifications
Comment on attachment 8746106 [details] [diff] [review]
Include "con" parameter in GCM message (v1)

We want push notifications to work, please uplift to aurora
Attachment #8746106 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Version: unspecified → 48 Branch
You need to log in before you can comment on or make changes to this bug.