1267860 - Push notification does not show payload string in Android devices

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[Abe - QA (:Abe_LV)]

The push notification does not display the payload string in Android devices. 
But it shows in desktop.

Steps to Reproduce:
1. Using Android device with latest nightly, go to :https://serviceworke.rs/push-payload_demo.html
2. Change Notification payload to contain string, like "testtext"
3. Press the [Request sending a notification!] button
4. Verify the notification displays the payload string, "testtext"

Actual Result:
Notification does not show payload.

Expected Result:
Notification should show the payload string.

Comment 1

[Edwin Wong [:edwong]]

:margaret - do we have anyone who can investigate this?

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

I believe jchen is working on this.

Comment 3

[Edwin Wong [:edwong]]

This is specific to encryption and sending encrypted payload to through the web push server.  Nalexander was working on this before.  I could be wrong, but jchen was working mostly on headless launch and processing of gcm event.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

I think I know what's going on.

Comment 5

[:Margaret Leibovic]

Awesome, thanks jchen. Let me know if you need someone from my team to help out.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Include "con" parameter in GCM message (v1)

Include the content encoding "con" parameter in the message that is
passed from GCM to Gecko, so that the message body can be correctly
decrypted.

Comment 7

[Lina Butler (ex-Mozilla)]

Comment on attachment 8746106 [details] [diff] [review]
Include "con" parameter in GCM message (v1)

Review of attachment 8746106 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks!

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce3035337782

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ce3035337782

Comment 10

[Michelle Funches - QA]

Fixed on Android Devices reference: https://docs.google.com/spreadsheets/d/1tXCl9QN7alRER292VsrXK_stxFB-4oVisr0TvkNpxkc/edit#gid=1832365738
Build ID 2016050303042

Comment 11

[Lina Butler (ex-Mozilla)]

jchen, should this be uplifted to Aurora?

Comment 12

[(inactive) Jim Chen [:jchen] [:darchons]]

Yep, thanks!

Comment 13

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8746106 [details] [diff] [review]
Include "con" parameter in GCM message (v1)

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Push notification cannot show messages
[Describe test coverage new/current, TreeHerder]: Locally, m-c
[Risks and why]: No risk; one line patch to fix the bug
[String/UUID change made/needed]: None

Comment 14

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: Push notifications

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8746106 [details] [diff] [review]
Include "con" parameter in GCM message (v1)

We want push notifications to work, please uplift to aurora

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking, issue in new feature

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e406359ce958