Closed Bug 1267876 Opened 8 years ago Closed 8 years ago

Make hazard analysis runnable on developer desktops

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It would be useful to be able to run the rooting hazard analysis on developers' desktops.

MozReview-Commit-ID: K6kMX8WD15g
Note that this only mentions Docker in passing, because I didn't want to bother with documenting what image to use and things. But I'm running this successfully on my Fedora desktop without Docker. Works great. Curious to see if it'll work for you.
Attachment #8745760 - Flags: review?(jorendorff)
Blocks: hazard
Comment on attachment 8745760 [details] [diff] [review]
Make usable on developer desktops

Review of attachment 8745760 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you so much for dropping everything and doing this. Ludicrously nice. Apart from me being dumb and setting SRCDIR to a relative dir, it ran great.

::: js/src/devtools/rootAnalysis/README.txt
@@ +1,1 @@
>  # Spidermonkey JSAPI rooting analysis

This file is really a markdown file; rename to README.md?

@@ +13,2 @@
>  
>  2.  Have the Gecko build prerequisites installed.

This also requires `tc-vcs`, which isn't a Gecko build prerequisite.

I was able to install it locally with

    npm install taskcluster-vcs
    export PATH="$PATH:$(pwd)/node_modules/.bin"

@@ +18,4 @@
>  
> +    mkdir work
> +    cd work
> +    GECKO_DIR=$SRCDIR $SRCDIR/testing/taskcluster/scripts/builder/build-haz-linux.sh $(pwd)

markdown nit: indent the line that says "run these commands:" to 4 spaces (I don't think it matters if the previous line is indented or not) and indent these three commands an additional 4 spaces.
Attachment #8745760 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/d55e3bc94309
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: