1267934 - Same version for release and ESR causes error on release notes

Status: RESOLVED FIXED

(www.mozilla.org :: Release notes, defect)

Description

[Josh Mize [:jgmize]]

This morning release notes were created for Firefox 45.0.1 ESR with an identical version string as for the release version of Firefox: '45.0.1'. This caused errors like https://rpm.newrelic.com/accounts/1299394/applications/13687785/filterable_errors#/show/d4cff6-708ffd18-0c41-11e6-8290-f8bc12425d4c/stack_trace?top_facet=transactionUiName&primary_facet=error.class&_k=rs3rug with the error message "rna.models:MultipleObjectsReturned: get() returned more than one Release -- it returned 2!" for this query: https://github.com/mozilla/bedrock/blob/master/bedrock/releasenotes/views.py#L53-L59

Comment 1

[Josh Mize [:jgmize]]

There is currently no differentiation in the URLs for release notes between the Release and ESR channels, and historically we have relied on different version numbers. When the numbers match, as in this case, we need to append 'esr' to the version to differentiate. I made this change in the nucleus admin to eliminate this error.

Due to the low volume of requests to this page the overall error rate was a fraction of a percent, which was below the error alert threshold. I only happened to notice it during a manual check of the error rate of bedrock when I noticed it was higher than normal. While the errors were occurring all day, end users did not actually see the 500 error pages due to Cloudflare continuing to serve a previously cached version of the page, which is the other reason no one else noticed this error until now.

Comment 2

[Josh Mize [:jgmize]]

:Sylvestre the 45.0.1 ESR notes are now available at https://www.mozilla.org/en-US/firefox/45.0.1esr/releasenotes/ and I'm adding a NI to make sure you see this and are aware of the need to use different versions between Release and ESR for release notes in the future.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

oups, my bad, thanks!