Closed Bug 1267985 Opened 4 years ago Closed 4 years ago

Fixup unified build error in DecoderDoctorDiagnostics.cpp

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: kaku, Assigned: kaku)

Details

Attachments

(1 file)

nsContentUtils and nsIScriptError are not defined but used.
Assignee: nobody → tkuo
Comment on attachment 8745959 [details]
MozReview Request: Bug 1267985 - include nsContentUtils.h and nsIScriptError.h; r=gerald

https://reviewboard.mozilla.org/r/49201/#review46073

I actually made local patches for these missing includes today! (But I didn't know there were actual errors, so I didn't push them then.)
So thank you for fixing these quickly, much appreciated.
Attachment #8745959 - Flags: review?(gsquelart) → review+
Comment on attachment 8745959 [details]
MozReview Request: Bug 1267985 - include nsContentUtils.h and nsIScriptError.h; r=gerald

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49201/diff/1-2/
Attachment #8745959 - Attachment description: MozReview Request: Bug 1267985 - include nsContentUtils.h and nsIScriptError.h; r?gerald → MozReview Request: Bug 1267985 - include nsContentUtils.h and nsIScriptError.h; r=gerald
https://reviewboard.mozilla.org/r/49201/#review46073

NP, I just happened to encounter this issue while rebasing:)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=87551128fb57

Try is good and thanks for the review.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ddebecaf6566
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.