Firebug theme: better CSS for memory heap-tree

RESOLVED FIXED in Firefox 49

Status

DevTools
Memory
RESOLVED FIXED
2 years ago
6 days ago

People

(Reporter: Honza, Assigned: Honza)

Tracking

unspecified
Firefox 49
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This is a follow up for bug 1266310

Just a little enhancement of the existing CSS.

Honza
(Assignee)

Updated

2 years ago
Assignee: nobody → odvarko
(Assignee)

Updated

2 years ago
Depends on: 1266310
(Assignee)

Comment 1

2 years ago
Created attachment 8746018 [details] [diff] [review]
bug1267998.patch

(In reply to Tim Nguyen :ntim from comment #7)
> Comment on attachment 8745341 [details] [diff] [review]
> bug1266310.patch
> 
> Review of attachment 8745341 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Seems like the other patch landed in fx-team [0], so you'll probably need to
> make this a follow up patch.
> 
> [0]: https://hg.mozilla.org/integration/fx-team/rev/146e4f2558c9
> 
> Anyway, this looks good to me, thanks for addressing my comments!
> 
> ::: devtools/client/themes/memory.css
> @@ +524,5 @@
> >  
> >  .heap-tree-item-individuals > button {
> >    height: 10px;
> >    width: 32px;
> > +  margin: 0 auto !important;
> 
> Can you add a comment on why !important is needed?

Done in the attached patch.
Honza
Attachment #8746018 - Flags: review?(ntim.bugs)

Updated

2 years ago
Attachment #8746018 - Flags: review?(ntim.bugs) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a308ab434d13
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49

Updated

2 years ago
Depends on: 1285455

Updated

6 days ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.