Lift cmp32set to the common MacroAssembler layer

RESOLVED FIXED in Firefox 52

Status

()

defect
P5
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: lth, Assigned: lth)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
All platforms implement cmp32set() and it is already used in platform-independent code such as SharedIC.cpp.
Assignee

Updated

3 years ago
Priority: -- → P5
Assignee

Comment 1

3 years ago
This actually has both cmp32Set and cmpPtrSet.  Needs a try run.
Attachment #8807558 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8807558 [details] [diff] [review]
bug1268006-cmpSet.patch

Review of attachment 8807558 [details] [diff] [review]:
-----------------------------------------------------------------

I do not really like having templates in the MacroAssembler public interface, as this does not gives guarantee about the existence of an implementation.
Which is why I would usually prefer if templates could be kept for the implementation instead of the interface, and use overloading to explicit the implementations which do exists.

Please open a follow-up and add a todo above these in the MacroAssembler.h.
Attachment #8807558 - Flags: review?(nicolas.b.pierron) → review+

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bb5895ace33f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.