1268012 - The separation line in reading list is incorrectly displayed on iPad Pro 12.9"

Status: RESOLVED FIXED

(Firefox for iOS :: Reading List, defect)

Description

[Catalin Suciu [:csuciu]]

Attachment: Screen Shot 2016-04-27 at 15.35.20.png

Device: iPad Pro 12.9" (9.3.1)

1. Add an article to reading list
2. Check the reading list

Result: The separation line between articles is not displayed on the entire length of the screen

Comment 1

[Maurya Talisetti]

Hi Farhan,

I tried a couple of things without much luck :-/
Would you be able to suggest any pointers?

In this section of code: https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Home/ReaderPanel.swift#L109,
I tried:
separatorInset = UIEdgeInsets(top: 0, left: 0, bottom: 0, right: 0)  // changed left inset to 0
It didn't result in any noticeable change.

I also tried removing the readStatusImageView and adjusted the ReadIndicator/TitleLable offsets. Though the cell title shifted to the extreme left, the separator remained where it is currently.

Comment 2

[Farhan Patel [:farhan]]

Try Debugging the view hierarchy to get a better understanding on how the view is laid out.
 
https://www.raywenderlich.com/98356/view-debugging-in-xcode-6

Comment 3

[Maurya Talisetti]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1974

Comment 4

[Farhan Patel [:farhan]]

Great job at finding the edge case! 

Comment 5

[Farhan Patel [:farhan]]

master 6f63c752f1686c4f1e5561fc3d6d02da93dc04f4

Comment 6

[Stephan Leroux [:sleroux]]

Needs uplift?

Comment 7

[Stephan Leroux [:sleroux]]

v5.x 70a8530