Closed
Bug 1268122
Opened 8 years ago
Closed 8 years ago
crash in java.lang.NullPointerException: Attempt to invoke virtual method ''void org.mozilla.gecko.gfx.LayerView.requestRender()'' on a null object reference at org.mozilla.gecko.gfx.GLController.resumeCompositor(GLController.java)
Categories
(Firefox for Android Graveyard :: Toolbar, defect)
Tracking
(firefox46 wontfix, firefox47 fixed, firefox48 fixed, firefox49 fixed, fennec47+)
RESOLVED
FIXED
Firefox 49
People
(Reporter: kbrosnan, Assigned: kats)
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
snorp
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details |
This bug was filed from the Socorro interface and is report bp-f47b0e44-e28b-44ec-852a-3ba992160426. ============================================================= New crash in 46 java.lang.NullPointerException: Attempt to invoke virtual method 'void org.mozilla.gecko.gfx.LayerView.requestRender()' on a null object reference at org.mozilla.gecko.gfx.GLController.resumeCompositor(GLController.java:287) at org.mozilla.gecko.gfx.GLController.updateCompositor(GLController.java:145) at org.mozilla.gecko.gfx.GLController$1.run(GLController.java:133) at android.os.Handler.handleCallback(Handler.java:739) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:211) at android.app.ActivityThread.main(ActivityThread.java:5373) at java.lang.reflect.Method.invoke(Native Method) at java.lang.reflect.Method.invoke(Method.java:372) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1020) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:815)
Assignee | ||
Comment 1•8 years ago
|
||
Unlike bug 1260451, this one is not specific to Android N. Looking at the code, maybe the LayerView is getting destroyed between serverSurfaceChanged posting the task, and the task getting run? It doesn't look like we guard against that.
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/49533/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49533/
Attachment #8746674 -
Flags: review?(snorp)
Comment on attachment 8746674 [details] MozReview Request: Bug 1268122 - Guard against layerview destruction between the compositor update task being posted and it running. r?snorp https://reviewboard.mozilla.org/r/49533/#review46359
Attachment #8746674 -
Flags: review?(snorp) → review+
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → bugmail.mozilla
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/69f4cf1125c2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8746674 [details] MozReview Request: Bug 1268122 - Guard against layerview destruction between the compositor update task being posted and it running. r?snorp Approval Request Comment [Feature/regressing bug #]: Unknown [User impact if declined]: Occasional crash under unknown conditions [Describe test coverage new/current, TreeHerder]: don't know how to repro, can't really test [Risks and why]: very low risk, simple null check [String/UUID change made/needed]: none
Attachment #8746674 -
Flags: approval-mozilla-beta?
Attachment #8746674 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 7•8 years ago
|
||
I found a couple of crash reports with comments: "Crashes frequently when unlocking the phone" "always happens when i switch back from another user" Most likely it's just a race condition that sometimes triggers when fennec is quickly opened and then put back into the background, so that we get the layer view surface created and then destroyed in quick succession.
Comment on attachment 8746674 [details] MozReview Request: Bug 1268122 - Guard against layerview destruction between the compositor update task being posted and it running. r?snorp Null check, crash fix, Aurora48+, Beta47+
Attachment #8746674 -
Flags: approval-mozilla-beta?
Attachment #8746674 -
Flags: approval-mozilla-beta+
Attachment #8746674 -
Flags: approval-mozilla-aurora?
Attachment #8746674 -
Flags: approval-mozilla-aurora+
Comment 9•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/c62a235f4825
Comment 10•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/91e6175328ac
Reporter | ||
Updated•8 years ago
|
tracking-fennec: ? → 47+
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•