nsScriptLoader::ShouldLoadScript is never called

RESOLVED FIXED in Firefox 49

Status

()

Core
DOM: Security
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: evilpie, Assigned: ckerschb)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
nsScriptLoader::ShouldLoadScript has no callers.
Flags: needinfo?(ckerschb)
(Assignee)

Comment 1

2 years ago
nsScriptLoader was converted to use asyncOpen2() within Bug 1194526. At the moment I can't recall why I didn't remove that function. I would assume there was a reason. If it is indeed not called anymore, we can definitely delete it.
Assignee: nobody → ckerschb
Blocks: 1194526
Status: NEW → ASSIGNED
Component: DOM → DOM: Security
Flags: needinfo?(ckerschb)
Whiteboard: [domsecurity-active]
(Assignee)

Comment 2

2 years ago
Created attachment 8746437 [details] [diff] [review]
bug_1268147_remove_nsscriptloader_shouldloadscript.patch

Jonas, please note that we can remove nsScriptLoader::ShouldLoadScript() but we can't remove nsScriptLoader::CheckContentPolicy() as suggested within [1] because we still need to call content policies on preloaded scripts [2].

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1194526#c27
[2] http://mxr.mozilla.org/mozilla-central/source/dom/base/nsScriptLoader.cpp#531
Attachment #8746437 - Flags: review?(jonas)

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a3c193dd2a9c
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.