Closed Bug 1268147 Opened 7 years ago Closed 7 years ago

nsScriptLoader::ShouldLoadScript is never called

Categories

(Core :: DOM: Security, defect)

Product:
Core
Component:
DOM: Security
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: evilpie, Assigned: ckerschb)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

bug_1268147_remove_nsscriptloader_shouldloadscript.patch
2.60 KB, patch
sicking
: review+
Details | Diff | Splinter Review 
nsScriptLoader::ShouldLoadScript has no callers.
nsScriptLoader was converted to use asyncOpen2() within Bug 1194526. At the moment I can't recall why I didn't remove that function. I would assume there was a reason. If it is indeed not called anymore, we can definitely delete it.
Assignee: nobody → ckerschb
Blocks: 1194526
Status: NEW → ASSIGNED
Component: DOM → DOM: Security
Flags: needinfo?(ckerschb)
Whiteboard: [domsecurity-active]
Jonas, please note that we can remove nsScriptLoader::ShouldLoadScript() but we can't remove nsScriptLoader::CheckContentPolicy() as suggested within [1] because we still need to call content policies on preloaded scripts [2].

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1194526#c27
[2] http://mxr.mozilla.org/mozilla-central/source/dom/base/nsScriptLoader.cpp#531
Attachment #8746437 - Flags: review?(jonas)
https://hg.mozilla.org/mozilla-central/rev/a3c193dd2a9c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.