1268154 - Remove add-on compatibility check when checking for updates and the associated preferences

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, defect)

Description

[Robert Strong (they/them - no direct email)]

In bug 1262880 the add-on compatibility check will be removed from app update.

Comment 1

[Kent James (:rkent)]

IIUC, this bug requires that we port the various changes (from /browser) in bug 1262880 to Thunderbird.

Comment 2

[Robert Strong (they/them - no direct email)]

Correct. Specifically patch browser changes rev1 and patch preference changes rev1

I typically throw up a Thunderbird patch with the changes and let someone on the Thunderbird side drive it into the c-c repo but if someone wants to fix this entirely by themselves that would be great. I'll submit a patch later today that someone can take the rest of the way if no one takes this on.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Bug1268154.patch

Robert, please could you check if this changes for TB are okay?

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 8746152 [details] [diff] [review]
Bug1268154.patch

Looks good to me! Thanks!

Comment 5

[Robert Strong (they/them - no direct email)]

If you are up for it could you also fix bug 1268180 for Thunderbird? Should be simpler than this bug.

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 8746152 [details] [diff] [review]
Bug1268154.patch

Thank you, Robert

Comment 7

[Richard Marti (:Paenglab)]

Attachment: Bug1268154.patch

I had also to implement the followup bug 1269219.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 8748203 [details] [diff] [review]
Bug1268154.patch

Review of attachment 8748203 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 9

[Richard Marti (:Paenglab)]

http://hg.mozilla.org/comm-central/rev/95b6c7ca6184