Remove add-on compatibility check when checking for updates and the associated preferences

RESOLVED FIXED in Thunderbird 49.0

Status

RESOLVED FIXED
3 years ago
3 months ago

People

(Reporter: rstrong, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 49.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

In bug 1262880 the add-on compatibility check will be removed from app update.
IIUC, this bug requires that we port the various changes (from /browser) in bug 1262880 to Thunderbird.
Correct. Specifically patch browser changes rev1 and patch preference changes rev1

I typically throw up a Thunderbird patch with the changes and let someone on the Thunderbird side drive it into the c-c repo but if someone wants to fix this entirely by themselves that would be great. I'll submit a patch later today that someone can take the rest of the way if no one takes this on.
(Assignee)

Comment 3

3 years ago
Created attachment 8746152 [details] [diff] [review]
Bug1268154.patch

Robert, please could you check if this changes for TB are okay?
Attachment #8746152 - Flags: feedback?(robert.strong.bugs)
Comment on attachment 8746152 [details] [diff] [review]
Bug1268154.patch

Looks good to me! Thanks!
Attachment #8746152 - Flags: feedback?(robert.strong.bugs) → feedback+
If you are up for it could you also fix bug 1268180 for Thunderbird? Should be simpler than this bug.
(Assignee)

Comment 6

3 years ago
Comment on attachment 8746152 [details] [diff] [review]
Bug1268154.patch

Thank you, Robert
Attachment #8746152 - Flags: review?(mkmelin+mozilla)
(Assignee)

Comment 7

3 years ago
Created attachment 8748203 [details] [diff] [review]
Bug1268154.patch

I had also to implement the followup bug 1269219.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8748203 - Flags: review?(mkmelin+mozilla)
(Assignee)

Updated

3 years ago
Attachment #8746152 - Attachment is obsolete: true
Attachment #8746152 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8748203 [details] [diff] [review]
Bug1268154.patch

Review of attachment 8748203 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #8748203 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 9

3 years ago
http://hg.mozilla.org/comm-central/rev/95b6c7ca6184
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
OS: Unspecified → All
Hardware: Unspecified → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 49.0
(Assignee)

Updated

3 years ago
Depends on: 1271042
Component: General → Add-Ons: General
You need to log in before you can comment on or make changes to this bug.