1268160 - Assert that PostIdleTask is only ever used on the main thread

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

No need to allow the plague to spread further.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8746126 [details] [diff] [review]
Patch

Review of attachment 8746126 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/chromium/src/base/message_loop.cc
@@ +270,5 @@
>  }
>  
>  void MessageLoop::PostIdleTask(already_AddRefed<Runnable> task) {
>    DCHECK(current() == this);
> +  MOZ_ASSERT(NS_IsMainThread());

Any reason not to make this a release assert, or at least a diagnostic assert?  (Same with the ones in MessagePump.)

::: xpcom/base/nsIMessageLoop.idl
@@ +12,5 @@
>   * instance, with some extra sugar added.  If you're calling from C++, it may
>   * or may not make sense for you to use this interface.  If you're calling from
>   * JS, you don't have a choice!
>   *
> + * Right now, you can only call PostIdleTask(), and the wrath of khuey is

This could also mention bug 1260828.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a9039d4e931

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7a9039d4e931