1268161 - IDL modification hook mismatch on different comm-* repos

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Patrick Cloke [:clokep]]

I ran into an issue (bug 1267273) when uplifting changes from comm-central to comm-aurora. I was surprised that that a commit [1] was able to be pushed to comm-central but then caused issues when uplifting; this implies to me that this hook is running on comm-aurora and NOT on comm-central. This is confusing.

It seems (re bug 1267273, comment 7) that we are following the policy of Firefox here and allowing binary changes without revving UUIDs for Thunderbird >= 46 (the version is different than Firefox). Thus, I think that comm-release, comm-beta, comm-aurora and comm-central should not have this hook running.

Does this match mozilla-release, mozilla-beta, mozilla-aurora and mozilla-central?

Pretty much I'm asking to ensure that the hooks enabled for these trees match the ones enabled for the mozilla-* trees. (Except for comm-esr45, which should definitely have this hook enabled.)

[1] https://hg.mozilla.org/comm-central/rev/158bced7b129

Comment 1

[Gregory Szorc [:gps]]

Removed prevent_idl_change_without_uuid_bump from the following repos:

* releases/comm-aurora
* releases/comm-beta

The comm-* repos match the mozilla-* ones. There's an open question on whether the hook still needs to be on release. But that's for another bug.

Comment 2

[Patrick Cloke [:clokep]]

Thanks!